From: Dan Carpenter <dan.carpenter@linaro.org>
To: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: av7110: coding style fixes: too many tabs
Date: Mon, 16 Mar 2026 18:34:03 +0300 [thread overview]
Message-ID: <abgi67iUDltHbfNM@stanley.mountain> (raw)
In-Reply-To: <20260316152340.238100-1-ss22.kern.dev@gmail.com>
On Mon, Mar 16, 2026 at 08:53:39PM +0530, Sudarshan Srinivasan wrote:
> This patch fixes below warning reported by checkpatch.pl
> WARNING: Too many leading tabs - consider code refactoring
>
> Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
> ---
> drivers/staging/media/av7110/av7110.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..f4709b2c4f41 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -958,8 +958,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
> dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
> dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
> ret = av7110_av_start_play(av7110, RP_AV);
> - if (!ret)
> - demux->playing = 1;
> + demux->playing = (ret) ? true : false
This isn't an improvement. Sorry.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-16 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 15:23 [PATCH] staging: media: av7110: coding style fixes: too many tabs Sudarshan Srinivasan
2026-03-16 15:34 ` Dan Carpenter [this message]
2026-03-18 19:32 ` [PATCH v2] " Sudarshan Srinivasan
2026-03-19 6:08 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-03-18 19:11 [PATCH] " Sudarshan Srinivasan
2026-03-19 6:37 ` Greg KH
2026-03-19 9:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abgi67iUDltHbfNM@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=ss22.kern.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox