* [PATCH] staging: media: av7110: coding style fixes: too many tabs
@ 2026-03-18 19:11 Sudarshan Srinivasan
2026-03-19 6:37 ` Greg KH
2026-03-19 9:02 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Sudarshan Srinivasan @ 2026-03-18 19:11 UTC (permalink / raw)
To: mchehab, gregkh
Cc: Sudarshan Srinivasan, linux-media, linux-staging, linux-kernel
This patch fixes below warning reported by checkpatch.pl
WARNING: Too many leading tabs - consider code refactoring
Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
---
drivers/staging/media/av7110/av7110.c | 32 ++++++++++++++++++---------
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 607992100baf..970343c4ec51 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -932,6 +932,27 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
return ret;
}
+static int handle_ts_memory_fe(struct dvb_demux_feed *feed,
+ struct dvb_demux *demux,
+ struct av7110 *av7110)
+{
+ int ret = 0;
+
+ if (feed->pes_type >= 2)
+ return 0;
+
+ if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
+ return 0;
+
+ dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
+ dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
+
+ ret = av7110_av_start_play(av7110, RP_AV);
+ demux->playing = (ret) ? true : false;
+
+ return ret;
+}
+
static int av7110_start_feed(struct dvb_demux_feed *feed)
{
struct dvb_demux *demux = feed->demux;
@@ -951,16 +972,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
(feed->pes_type <= DMX_PES_PCR)) {
switch (demux->dmx.frontend->source) {
case DMX_MEMORY_FE:
- if (feed->ts_type & TS_DECODER)
- if (feed->pes_type < 2 &&
- !(demux->pids[0] & 0x8000) &&
- !(demux->pids[1] & 0x8000)) {
- dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
- dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
- ret = av7110_av_start_play(av7110, RP_AV);
- if (!ret)
- demux->playing = 1;
- }
+ ret = handle_ts_memory_fe(feed, demux, av7110);
break;
default:
ret = dvb_feed_start_pid(feed);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: media: av7110: coding style fixes: too many tabs
2026-03-18 19:11 [PATCH] staging: media: av7110: coding style fixes: too many tabs Sudarshan Srinivasan
@ 2026-03-19 6:37 ` Greg KH
2026-03-19 9:02 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2026-03-19 6:37 UTC (permalink / raw)
To: Sudarshan Srinivasan; +Cc: mchehab, linux-media, linux-staging, linux-kernel
On Thu, Mar 19, 2026 at 12:41:47AM +0530, Sudarshan Srinivasan wrote:
> This patch fixes below warning reported by checkpatch.pl
> WARNING: Too many leading tabs - consider code refactoring
>
> Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
> ---
> drivers/staging/media/av7110/av7110.c | 32 ++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..970343c4ec51 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -932,6 +932,27 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
> return ret;
> }
>
> +static int handle_ts_memory_fe(struct dvb_demux_feed *feed,
> + struct dvb_demux *demux,
> + struct av7110 *av7110)
> +{
> + int ret = 0;
> +
> + if (feed->pes_type >= 2)
> + return 0;
> +
> + if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
> + return 0;
> +
> + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
> + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
> +
> + ret = av7110_av_start_play(av7110, RP_AV);
> + demux->playing = (ret) ? true : false;
> +
> + return ret;
> +}
I think you still have too many tabs here :(
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: media: av7110: coding style fixes: too many tabs
2026-03-18 19:11 [PATCH] staging: media: av7110: coding style fixes: too many tabs Sudarshan Srinivasan
2026-03-19 6:37 ` Greg KH
@ 2026-03-19 9:02 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-03-19 9:02 UTC (permalink / raw)
To: Sudarshan Srinivasan
Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel
On Thu, Mar 19, 2026 at 12:41:47AM +0530, Sudarshan Srinivasan wrote:
> This patch fixes below warning reported by checkpatch.pl
> WARNING: Too many leading tabs - consider code refactoring
>
> Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
> ---
> drivers/staging/media/av7110/av7110.c | 32 ++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..970343c4ec51 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -932,6 +932,27 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
> return ret;
> }
>
> +static int handle_ts_memory_fe(struct dvb_demux_feed *feed,
> + struct dvb_demux *demux,
> + struct av7110 *av7110)
> +{
> + int ret = 0;
> +
> + if (feed->pes_type >= 2)
> + return 0;
> +
> + if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
> + return 0;
> +
> + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
> + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
> +
> + ret = av7110_av_start_play(av7110, RP_AV);
> + demux->playing = (ret) ? true : false;
Keep this as:
if (!ret)
demux->playing = true;
1: It matches the original code. Don't make unnecessary style changes.
2: The original better style. The old code said, if there were no
errors set playing to true. The new code is ambiguous. You might
think ret is a bool or something.
3: How do we know that the playing wasn't true at the start? This
could potentially introduce a behavior change. That wasn't
mentioned in the commit message.
> +
> + return ret;
> +}
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: media: av7110: coding style fixes: too many tabs
@ 2026-03-16 15:23 Sudarshan Srinivasan
2026-03-16 15:34 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Sudarshan Srinivasan @ 2026-03-16 15:23 UTC (permalink / raw)
To: mchehab, gregkh
Cc: Sudarshan Srinivasan, linux-media, linux-staging, linux-kernel
This patch fixes below warning reported by checkpatch.pl
WARNING: Too many leading tabs - consider code refactoring
Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
---
drivers/staging/media/av7110/av7110.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 607992100baf..f4709b2c4f41 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -958,8 +958,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
ret = av7110_av_start_play(av7110, RP_AV);
- if (!ret)
- demux->playing = 1;
+ demux->playing = (ret) ? true : false
}
break;
default:
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: media: av7110: coding style fixes: too many tabs
2026-03-16 15:23 Sudarshan Srinivasan
@ 2026-03-16 15:34 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-03-16 15:34 UTC (permalink / raw)
To: Sudarshan Srinivasan
Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel
On Mon, Mar 16, 2026 at 08:53:39PM +0530, Sudarshan Srinivasan wrote:
> This patch fixes below warning reported by checkpatch.pl
> WARNING: Too many leading tabs - consider code refactoring
>
> Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
> ---
> drivers/staging/media/av7110/av7110.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..f4709b2c4f41 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -958,8 +958,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed)
> dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
> dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
> ret = av7110_av_start_play(av7110, RP_AV);
> - if (!ret)
> - demux->playing = 1;
> + demux->playing = (ret) ? true : false
This isn't an improvement. Sorry.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-19 9:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 19:11 [PATCH] staging: media: av7110: coding style fixes: too many tabs Sudarshan Srinivasan
2026-03-19 6:37 ` Greg KH
2026-03-19 9:02 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-03-16 15:23 Sudarshan Srinivasan
2026-03-16 15:34 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox