public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: av7110: remove dead code in av7110.c
Date: Thu, 19 Mar 2026 18:45:55 +0300	[thread overview]
Message-ID: <abwaM9N8D34zq53y@stanley.mountain> (raw)
In-Reply-To: <20260319-av7110-dead-code-v1-1-da6e76804817@yahoo.pl>

On Thu, Mar 19, 2026 at 11:16:37AM +0100, Tomasz Unger wrote:
> Remove two commented-out lines of dead code that serve no purpose.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Checked with scripts/checkpatch.pl - no errors, no warnings.
> ---
>  drivers/staging/media/av7110/av7110.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..490963c0ccce 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -314,7 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len,
>  	}
>  }
>  
> -//#define DEBUG_TIMING
>  static inline void print_time(char *s)
>  {
>  #ifdef DEBUG_TIMING
   ^^^^^^^^^^^^^^^^^^^
Get rid of this stuff too.

> @@ -762,7 +761,6 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter)
>  	u16 buf[20];
>  	int ret, i;
>  	u16 handle;
> -//	u16 mode = 0x0320;

At that point, you'll probably want to split it into two patches.

regards,
dan carpenter

>  	u16 mode = 0xb96a;
>  
>  	dprintk(4, "%p\n", av7110);
> 


  reply	other threads:[~2026-03-19 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260319-av7110-dead-code-v1-1-da6e76804817.ref@yahoo.pl>
2026-03-19 10:16 ` [PATCH] staging: media: av7110: remove dead code in av7110.c Tomasz Unger
2026-03-19 15:45   ` Dan Carpenter [this message]
     [not found] <20260320-av7110-dead-code-v1-1-70ad36eba662.ref@yahoo.pl>
2026-03-20  7:31 ` Tomasz Unger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abwaM9N8D34zq53y@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=tomasz.unger@yahoo.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox