From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Anushka Badhe <anushkabadhe@gmail.com>
Cc: dan.carpenter@linaro.org, andy@kernel.org,
gregkh@linuxfoundation.org, hansg@kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
mchehab@kernel.org, sakari.ailus@linux.intel.com
Subject: Re: [PATCH v2] staging: atomisp: vf_1.0: fix open brace placement
Date: Mon, 23 Mar 2026 13:09:39 +0200 [thread overview]
Message-ID: <acEfc4Mzg1TsD92w@ashevche-desk.local> (raw)
In-Reply-To: <20260323102104.44021-1-anushkabadhe@gmail.com>
On Mon, Mar 23, 2026 at 03:51:04PM +0530, Anushka Badhe wrote:
> Fix open brace placement on function definitions and control statements
> to comply with kernel coding style.
...
> sh_css_vf_downscale_log2(
> const struct ia_css_frame_info *out_info,
> const struct ia_css_frame_info *vf_info,
> - unsigned int *downscale_log2) {
> + unsigned int *downscale_log2)
> +{
The indentation of the entire function is broken and needs to be fixed.
And IIRC there were already 3+ patches on the same, so please try instead
helping with reviewing existing stream on AtomISP patches.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-23 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 9:30 [PATCH] staging: atomisp: vf_1.0: fix open brace placement Anushka Badhe
2026-03-23 9:52 ` Dan Carpenter
2026-03-23 10:21 ` [PATCH v2] " Anushka Badhe
2026-03-23 10:45 ` Dan Carpenter
2026-03-23 11:09 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acEfc4Mzg1TsD92w@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=anushkabadhe@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox