From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Anushka Badhe <anushkabadhe@gmail.com>
Cc: gregkh@linuxfoundation.org, mchehab@kernel.org, hansg@kernel.org,
andy@kernel.org, sakari.ailus@linux.intel.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line
Date: Tue, 24 Mar 2026 13:50:32 +0200 [thread overview]
Message-ID: <acJ6iD5FGE2ZlORd@ashevche-desk.local> (raw)
In-Reply-To: <20260324081007.23165-1-anushkabadhe@gmail.com>
On Tue, Mar 24, 2026 at 01:40:07PM +0530, Anushka Badhe wrote:
> Removed the whitespace at the start of the line to comply with
> linux kernel coding style.
Linux
...
> const hrt_address GP_TIMER_BASE =
> - (hrt_address)0x0000000000000600ULL;
> + (hrt_address)0x0000000000000600ULL;
Always think one or even two steps further. How does your patch add value?
For now it's just a warning of a tool or even no warning, just some whitespace
shuffling, which is usually the type of patches that are doomed to be ceased.
Compare to
const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
which gives the same result + reduces number of LoC for free. This increases
the value of the change. Now, you can look at the rest of the code for the
indentation problems.
BUT, they are so-o-o-o LOW priority thing, that most likely will be simply
NAKed. Can you rather do a real patch instead, please?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-24 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 8:10 [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line Anushka Badhe
2026-03-24 11:50 ` Andy Shevchenko [this message]
2026-03-24 11:51 ` Andy Shevchenko
2026-03-24 18:08 ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Anushka Badhe
2026-03-24 19:43 ` [PATCH v3] staging: media: " Anushka Badhe
2026-03-25 12:08 ` Andy Shevchenko
2026-03-25 13:24 ` [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration Anushka Badhe
2026-03-26 10:48 ` Andy Shevchenko
2026-03-25 8:45 ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Greg KH
2026-03-25 9:12 ` Anushka B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJ6iD5FGE2ZlORd@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=anushkabadhe@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox