From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Matthias Fend <matthias.fend@emfend.at>
Cc: Jimmy Su <jimmy.su@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH v2 8/9] media: i2c: ov08d10: add support for reset and power management
Date: Tue, 24 Mar 2026 12:32:25 +0200 [thread overview]
Message-ID: <acJoOZjTCQMQTbv7@kekkonen.localdomain> (raw)
In-Reply-To: <47cee08f-4500-48ee-aea6-afba5a611211@emfend.at>
Hi Mathias,
On Tue, Mar 24, 2026 at 09:12:40AM +0100, Matthias Fend wrote:
> > > @@ -1403,12 +1467,32 @@ static int ov08d10_probe(struct i2c_client *client)
> > > return ret;
> > > }
> > > + ov08d10->reset = devm_reset_control_get_optional_exclusive(ov08d10->dev, NULL);
> > > + if (IS_ERR(ov08d10->reset))
> > > + return dev_err_probe(ov08d10->dev, PTR_ERR(ov08d10->reset),
> > > + "failed to get reset\n");
> > > + reset_control_assert(ov08d10->reset);
> > > +
> > > + for (i = 0; i < ARRAY_SIZE(ov08d10_supply_names); i++)
> >
> > You can declare i here.
>
> Right. But since the variable will also be needed in other places in the
> next commit, it would have to be moved again. Therefore, in the end, might
> it be simpler to leave it where it is?
Ack, sounds good.
--
Sakari Ailus
next prev parent reply other threads:[~2026-03-24 10:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 17:07 [PATCH v2 0/9] drivers: media: i2c: Omnivision OV08D10 improvements Matthias Fend
2026-03-09 17:07 ` [PATCH v2 1/9] media: i2c: ov08d10: fix runtime PM handling in probe Matthias Fend
2026-03-10 9:12 ` Philipp Zabel
2026-03-09 17:07 ` [PATCH v2 2/9] media: i2c: ov08d10: fix image vertical start setting Matthias Fend
2026-03-09 17:07 ` [PATCH v2 3/9] media: i2c: ov08d10: remove duplicate register write Matthias Fend
2026-03-09 17:07 ` [PATCH v2 4/9] media: i2c: ov08d10: fix some typos in comments Matthias Fend
2026-03-09 17:07 ` [PATCH v2 5/9] media: i2c: ov08d10: add missing newline to prints Matthias Fend
2026-03-09 17:07 ` [PATCH v2 6/9] dt-bindings: media: i2c: document Omnivision OV08D10 CMOS image sensor Matthias Fend
2026-03-10 8:27 ` Krzysztof Kozlowski
2026-03-17 8:44 ` Sakari Ailus
2026-03-09 17:07 ` [PATCH v2 7/9] media: i2c: ov08d10: add support for binding via device tree Matthias Fend
2026-03-09 17:07 ` [PATCH v2 8/9] media: i2c: ov08d10: add support for reset and power management Matthias Fend
2026-03-17 8:46 ` Sakari Ailus
2026-03-24 8:12 ` Matthias Fend
2026-03-24 10:32 ` Sakari Ailus [this message]
2026-03-09 17:07 ` [PATCH v2 9/9] media: i2c: ov08d10: add support for 24 MHz input clock Matthias Fend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJoOZjTCQMQTbv7@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jimmy.su@intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthias.fend@emfend.at \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox