From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Michael Riesch <michael.riesch@collabora.com>
Cc: Elgin Perumbilly <elgin.perumbilly@siliconsignals.io>,
tarang.raval@siliconsignals.io,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: imx415: Drop redundant runtime PM callbacks
Date: Wed, 25 Mar 2026 14:28:12 +0200 [thread overview]
Message-ID: <acPU3H9pYEwzuuOS@kekkonen.localdomain> (raw)
In-Reply-To: <1378ed13-6744-422a-b0b8-02621117238f@collabora.com>
Hi Michael,
On Tue, Mar 24, 2026 at 08:42:31PM +0100, Michael Riesch wrote:
> Hi Elgin,
>
> Thanks for the patch but...
>
> On 3/24/26 13:45, Elgin Perumbilly wrote:
> > Replace runtime_suspend/resume wrappers by using power helpers
> > directly with DEFINE_RUNTIME_DEV_PM_OPS().
>
> ...why? What advantage does this refactoring bring?
It looks like patch removes two redundant functions, doesn't it? :-)
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2026-03-25 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 12:45 [PATCH] media: i2c: imx415: Drop redundant runtime PM callbacks Elgin Perumbilly
2026-03-24 19:42 ` Michael Riesch
2026-03-25 12:28 ` Sakari Ailus [this message]
2026-03-25 19:36 ` Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acPU3H9pYEwzuuOS@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=elgin.perumbilly@siliconsignals.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox