From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Anushka Badhe <anushkabadhe@gmail.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org, hansg@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Subject: Re: [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration
Date: Thu, 26 Mar 2026 12:48:34 +0200 [thread overview]
Message-ID: <acUPAphWdppMoFBw@ashevche-desk.local> (raw)
In-Reply-To: <20260325132434.55775-1-anushkabadhe@gmail.com>
On Wed, Mar 25, 2026 at 06:54:34PM +0530, Anushka Badhe wrote:
> Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
> readability.
Nice, but this constant is only used in one file, id est gp_timer.c.
Just move it there with the (fixed style of the) comment to there
and drop the mentioning in the rest of the files. With this being done,
the patch gains real value.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-26 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 8:10 [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line Anushka Badhe
2026-03-24 11:50 ` Andy Shevchenko
2026-03-24 11:51 ` Andy Shevchenko
2026-03-24 18:08 ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Anushka Badhe
2026-03-24 19:43 ` [PATCH v3] staging: media: " Anushka Badhe
2026-03-25 12:08 ` Andy Shevchenko
2026-03-25 13:24 ` [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration Anushka Badhe
2026-03-26 10:48 ` Andy Shevchenko [this message]
2026-03-25 8:45 ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Greg KH
2026-03-25 9:12 ` Anushka B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acUPAphWdppMoFBw@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=anushkabadhe@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox