From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9683644C0 for ; Fri, 27 Mar 2026 16:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774630743; cv=none; b=N3FV8DrypTRjGrn1YjpbdgvaRCTTGlA5s5wzMoWpU3k0QACQCw7KgliHgFHD2XCXF9UDH356BMYJvIUYqUReLi3b96qQow2MCmIHckeFJ5UkAB6BgO7fzWZmXJDQF/+gXamIsKwlbBSPup5j4iDBindYJ2d3SragW0Xtx5YFfVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774630743; c=relaxed/simple; bh=XKIMTUUdp+NNsC503uaHBJTvWwsTadMFUv6PMoGoDZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EBt4+aGVDhiImnZ2bFYa5/YuvFxdbhQqPByPmePl8yPnX4WndQbpJTwfQSFopE0Qwa8rrfVCvIvXd/9/4pC5bkI+Q+FcRFGK1Ro4GyD44fVmfqpMuahcZw+D/njqbZCAYQu2jn0Wb6LRpKJWkJ1ge5dCZud+VPrWrcR8N3v2QiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=vHYlJXbW; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vHYlJXbW" Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D72421CD; Fri, 27 Mar 2026 17:57:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774630659; bh=XKIMTUUdp+NNsC503uaHBJTvWwsTadMFUv6PMoGoDZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vHYlJXbWk/rMZqNUMAS31h9umhM7G4acSw3Nyg9j88m19KDGqfk01AD9pm3vyBPp7 sRS5nzWiT0JBr8E9hR3j7ExmSQiNDBSSXfQZYzo2ViU1LC3TW8ptGHjivLOt0WBYSG 3Kjfm0aBOYa1YwTGuHb6W09OEYh9yRAdNJNl8PpU= Date: Fri, 27 Mar 2026 17:58:55 +0100 From: Jacopo Mondi To: David Carlier Cc: Daniel Scally , Jacopo Mondi , Mauro Carvalho Chehab , Nayden Kanchev , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH v3 1/3] media: mali-c55: add missing of_reserved_mem_device_release() Message-ID: References: <20260327150707.256752-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260327150707.256752-1-devnexen@gmail.com> Hi David On Fri, Mar 27, 2026 at 03:07:05PM +0000, David Carlier wrote: > mali_c55_probe() calls of_reserved_mem_device_init() to associate > reserved memory regions with the device. This function allocates a > struct rmem_assigned_device and adds it to a global linked list, which > must be explicitly released via of_reserved_mem_device_release() — there > is no devm variant of this API. > > However, neither the probe error paths nor mali_c55_remove() called > of_reserved_mem_device_release(). Any probe failure after the > of_reserved_mem_device_init() call, as well as every normal device > removal, leaked the reserved memory association on the global list. > > Fix this by adding an err_release_mem label at the end of the probe > error chain and calling of_reserved_mem_device_release() in > mali_c55_remove(). The remove teardown order is also corrected to call > mali_c55_media_frameworks_deinit() before kfree(), mirroring the probe > init order in reverse. > > Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") > Signed-off-by: David Carlier Reviewed-by: Jacopo Mondi With your permission, I'll take these three patches in a follow-up series that fixes the module loading/unloading. I could also specify it as pre-requisite to b4, I'll see what's easier Thanks j > --- > drivers/media/platform/arm/mali-c55/mali-c55-core.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c > index c1a562cd214e..5cb59c70ffc9 100644 > --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c > +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c > @@ -806,8 +806,10 @@ static int mali_c55_probe(struct platform_device *pdev) > vb2_dma_contig_set_max_seg_size(dev, UINT_MAX); > > ret = __mali_c55_power_on(mali_c55); > - if (ret) > - return dev_err_probe(dev, ret, "failed to power on\n"); > + if (ret) { > + dev_err_probe(dev, ret, "failed to power on\n"); > + goto err_release_mem; > + } > > ret = mali_c55_check_hwcfg(mali_c55); > if (ret) > @@ -846,6 +848,8 @@ static int mali_c55_probe(struct platform_device *pdev) > kfree(mali_c55->context.registers); > err_power_off: > __mali_c55_power_off(mali_c55); > +err_release_mem: > + of_reserved_mem_device_release(dev); > > return ret; > } > @@ -854,8 +858,9 @@ static void mali_c55_remove(struct platform_device *pdev) > { > struct mali_c55 *mali_c55 = platform_get_drvdata(pdev); > > - kfree(mali_c55->context.registers); > mali_c55_media_frameworks_deinit(mali_c55); > + kfree(mali_c55->context.registers); > + of_reserved_mem_device_release(&pdev->dev); > } > > static const struct of_device_id mali_c55_of_match[] = { > -- > 2.53.0 > >