Re: [PATCH v3 2/3] media: mali-c55: add missing pm_runtime_disable() in remove

[Jacopo Mondi <jacopo.mondi@ideasonboard.com>]

Hi David

On Fri, Mar 27, 2026 at 03:07:06PM +0000, David Carlier wrote:
> pm_runtime_enable() is called during probe but mali_c55_remove() never
> calls pm_runtime_disable(), leaving the device's runtime PM state
> enabled after the driver is unbound.
>
> Add the missing pm_runtime_disable() call to the remove path.

The driver doesn't depend on PM, so we need to explicitly power-off
the peripheral in remove() (and set the pm_runtime status to
suspended)

>
> Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver")
> Signed-off-by: David Carlier <devnexen@gmail.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

This patch is however correct, I'll add the power-off on top.

> ---
>  drivers/media/platform/arm/mali-c55/mali-c55-core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 5cb59c70ffc9..38b11d5ba168 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -859,6 +859,7 @@ static void mali_c55_remove(struct platform_device *pdev)
>  	struct mali_c55 *mali_c55 = platform_get_drvdata(pdev);
>
>  	mali_c55_media_frameworks_deinit(mali_c55);
> +	pm_runtime_disable(&pdev->dev);
>  	kfree(mali_c55->context.registers);
>  	of_reserved_mem_device_release(&pdev->dev);
>  }
> --
> 2.53.0
>
>