From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF333C9ED6; Tue, 31 Mar 2026 11:26:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774956385; cv=none; b=o+uGmZ1muandneG+Niff7uZhIQQXwVcym+vPRYQZDIS6sJMrNE2NqlHHqcxTPyDyP2O3lqE8d7lCSJydcsvuMPCYx7vXSxQdDOwww36W6EW8DYMvQnCqZewmfgEfr1x75jTD8F13LSbskaj3gp9V6FRBfge+a6lb71G5HDusLm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774956385; c=relaxed/simple; bh=N/mQYhYQQrRo4NLHgCUCabELDBvHZDt6H+0yldm8uhY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l1zF7KAJukODFiiQsVM27qrEAFQukkfEvFUyIiopXUV+7QYT9auRcAduqb76rvhnOnDEYjR7h64Pxacz4KFiuvCksKtrg/YWtRmJ6/W/AfMEmI45FQ860eA9x8mxkjUHPT2+Esnbb5EV2xx/tUX6+vz1fh2wx1edynfCNHSnYSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QDfVqfub; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QDfVqfub" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774956383; x=1806492383; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=N/mQYhYQQrRo4NLHgCUCabELDBvHZDt6H+0yldm8uhY=; b=QDfVqfub3oIG9X8jyx0GCe1SQ5slF6vrnJJI1ezHPHqwAYKcAVqg4Xd3 JpVWpkK7/N19ANNLnS/5FL0YObMITD83F0F9CoPptA426VSzyJ0XDVs7s MvC5l2ILRKy28U2exR1DgNH+FCylK281DIZS0Nmre2U2UbFu8+F/uQm30 WpvTAjQhVIO2aHVxo+j+s3b41zUEBvhU3iuRy8ZW+ypbfg/hxArUiA926 MTY3/mAHWTaGi0vjnXBRSKokUB7rtUOwrFKH1wxxnSO9ADBtQ5k/5I76r zAf6XaMoAbsEdaSBSg06lSW1rAPijUmmO+d4Tvp6hw59vYX6L0aYTDteu g==; X-CSE-ConnectionGUID: 2SEArNToQI2fGBeG8SALzg== X-CSE-MsgGUID: kGIriwH2RYiXElO/Z+6qNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11744"; a="76157983" X-IronPort-AV: E=Sophos;i="6.23,151,1770624000"; d="scan'208";a="76157983" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2026 04:26:23 -0700 X-CSE-ConnectionGUID: iqfrEEUOSI6z18Sr2XXEig== X-CSE-MsgGUID: QoMVoXdOTxq0IgJ25L1mZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,151,1770624000"; d="scan'208";a="225333936" Received: from abityuts-desk.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.233]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2026 04:26:21 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 1B8A8121D53; Tue, 31 Mar 2026 14:26:28 +0300 (EEST) Date: Tue, 31 Mar 2026 14:26:28 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Arun T Cc: johannes.goede@oss.qualcomm.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: Re: [PATCH v6 1/2] platform/x86: int3472: Add TPS68470 board data for Intel nvl Message-ID: References: <20260327181959.3528753-1-arun.t@intel.com> <20260327181959.3528753-2-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260327181959.3528753-2-arun.t@intel.com> Hi Arun, On Fri, Mar 27, 2026 at 11:49:57PM +0530, Arun T wrote: > The Intel NVL platform uses IPU8 is powered by a TPS68470 PMIC,requiring board > data to configure the GPIOs and regulators for proper camera sensor operation. Please run scripts/checkpatch.pl on this. Could you rebase these on Antti's patches adding support for an MSI laptop? They're here . > > Signed-off-by: Arun T > Reviewed-by: Daniel Scally > --- > .../x86/intel/int3472/tps68470_board_data.c | 121 ++++++++++++++++++ > 1 file changed, 121 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > index 71357a036292..f0309fd1e515 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > @@ -143,6 +143,20 @@ static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { > REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), > }; > > +/* Settings for Intel NVL platform */ > + > +static struct regulator_consumer_supply ovti13b1_core_consumer_supplies[] = { > + REGULATOR_SUPPLY("dvdd", "i2c-OVTI13B1:01"), > +}; > + > +static struct regulator_consumer_supply ovti13b1_ana_consumer_supplies[] = { > + REGULATOR_SUPPLY("avdd", "i2c-OVTI13B1:01"), > +}; > + > +static struct regulator_consumer_supply ovti13b1_vsio_consumer_supplies[] = { > + REGULATOR_SUPPLY("dovdd", "i2c-OVTI13B1:01"), > +}; > + > static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data = { > .constraints = { > .min_uV = 1200000, > @@ -220,6 +234,77 @@ static const struct regulator_init_data dell_7212_tps68470_aux2_reg_init_data = > .consumer_supplies = int3479_aux2_consumer_supplies, > }; > > +static const struct regulator_init_data intel_nvl_tps68470_core_reg_init_data = { > + .constraints = { > + .min_uV = 1200000, > + .max_uV = 1200000, > + .apply_uV = true, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(ovti13b1_core_consumer_supplies), > + .consumer_supplies = ovti13b1_core_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_ana_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = true, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(ovti13b1_ana_consumer_supplies), > + .consumer_supplies = ovti13b1_ana_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = true, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + > +}; > + > +/* Ensure the always-on VIO regulator has the same voltage as VSIO */ > +static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = true, > + .always_on = true, > + }, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = true, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(ovti13b1_vsio_consumer_supplies), > + .consumer_supplies = ovti13b1_vsio_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_aux1_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_aux2_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > +}; > + > static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = { > .reg_init_data = { > [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, > @@ -232,6 +317,18 @@ static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = > }, > }; > > +static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pdata = { > + .reg_init_data = { > + [TPS68470_CORE] = &intel_nvl_tps68470_core_reg_init_data, > + [TPS68470_ANA] = &intel_nvl_tps68470_ana_reg_init_data, > + [TPS68470_VCM] = &intel_nvl_tps68470_vcm_reg_init_data, > + [TPS68470_VIO] = &intel_nvl_tps68470_vio_reg_init_data, > + [TPS68470_VSIO] = &intel_nvl_tps68470_vsio_reg_init_data, > + [TPS68470_AUX1] = &intel_nvl_tps68470_aux1_reg_init_data, > + [TPS68470_AUX2] = &intel_nvl_tps68470_aux2_reg_init_data, Vcm, aux1 and aux2 appear to be unused. Is there a need to configure them? > + }, > +}; > + > static struct gpiod_lookup_table surface_go_int347a_gpios = { > .dev_id = "i2c-INT347A:00", > .table = { > @@ -258,6 +355,14 @@ static struct gpiod_lookup_table dell_7212_int3479_gpios = { > } > }; > > +static struct gpiod_lookup_table intel_nvl_ovti13b1_gpios = { > + .dev_id = "i2c-OVTI13B1:01", > + .table = { > + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), > + { } > + } > +}; > + > static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = { > .dev_name = "i2c-INT3472:05", > .tps68470_regulator_pdata = &surface_go_tps68470_pdata, > @@ -287,6 +392,15 @@ static const struct int3472_tps68470_board_data dell_7212_tps68470_board_data = > }, > }; > > +static const struct int3472_tps68470_board_data intel_nvl_tps68470_board_data = { > + .dev_name = "i2c-INT3472:04", > + .tps68470_regulator_pdata = &intel_nvl_tps68470_pdata, > + .n_gpiod_lookups = 1, > + .tps68470_gpio_lookup_tables = { > + &intel_nvl_ovti13b1_gpios, > + }, > +}; > + > static const struct dmi_system_id int3472_tps68470_board_data_table[] = { > { > .matches = { > @@ -316,6 +430,13 @@ static const struct dmi_system_id int3472_tps68470_board_data_table[] = { > }, > .driver_data = (void *)&dell_7212_tps68470_board_data, > }, > + { > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Nova Lake Client Platform"), > + }, > + .driver_data = (void *)&intel_nvl_tps68470_board_data, > + }, > { } > }; > -- Regards, Sakari Ailus