From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C963BE652 for ; Thu, 9 Apr 2026 12:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775738292; cv=none; b=qtK+W3fTRpEY978ErPK0JuRkrCsaN+dmWW18BskVCy17mylVy8/IwCMvKzMlTEHimAog0hLRBIpH2yH7YtDVA4QzaWFaTvq+YLzpnzmiW5h+YJa29ptQGLIZ6tHocx7I4x5NMqbd3kdTh6u8cR1zyUXHlNArvvY1PzAUj38i6xE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775738292; c=relaxed/simple; bh=d1+Vn1+nmxQUEpEEZem6yPloSUx3IAA5s3+3Sci+Ir0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lh1WcakNLnLHK3qerzFt9639KTN9jE+6th4hY5eFE2Zw9Lw3Fswz0QSRMRUpDWhoXDXUG7PjdPno6sZX3rSNquiLo/7UK+pv5AQfoqd/feaJfanPIAogzpWEP6RKMAgOWCNu7OgIoEufbzfrnODEWyMwI9oic92VmQmbT8gZ6t0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M2IAl2WF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M2IAl2WF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 931EFC19424; Thu, 9 Apr 2026 12:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775738292; bh=d1+Vn1+nmxQUEpEEZem6yPloSUx3IAA5s3+3Sci+Ir0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M2IAl2WFlmirhF6vkuPjE6CbkOOQke4RMNkNasosllkTXMB0eoDY8D6cOPPPKsWPK AlIDQ+RyMTqhs61avp173c3TxXaIQw4KEsnIs0qR+vbKe2zLOWWdhOd+3vjRbL1cXc WKAT2RYWanJA6tX6O7yjwINYgQDeE42lfWvnrItEV3Pl2JCq9Z6quKO0RacCoDhanK JRZQOtpaT4Icsk3goBrvmhsuJCKPiPpLO4qMMbIkgtVqkncIlemTDiEBFg5Cg4koWr WctFfznlq21DLOPmSmFsTvJ+iNK6XMaJhu343AZCN3jKr12yPD4ZSliNVG3Njwoc9N eskYmSGFg+x/A== Date: Thu, 9 Apr 2026 14:38:07 +0200 From: Andi Shyti To: Christian =?utf-8?B?S8O2bmln?= Cc: janusz.krzysztofik@intel.com, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org, gaoxiang17@xiaomi.com, sumit.semwal@linaro.org Subject: Re: [PATCH] dma-buf: fix order of trace and fput Message-ID: References: <20260408122437.1364-1-christian.koenig@amd.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408122437.1364-1-christian.koenig@amd.com> Hi Christian, > @@ -845,9 +845,8 @@ void dma_buf_put(struct dma_buf *dmabuf) > if (WARN_ON(!dmabuf || !dmabuf->file)) > return; > > - fput(dmabuf->file); > - > DMA_BUF_TRACE(trace_dma_buf_put, dmabuf); > + fput(dmabuf->file); funny, I just found out I sent the exact same patch, just few minutes later :-) [*] Andi > } [*] https://lore.kernel.org/all/20260408123916.2604101-2-andi.shyti@kernel.org/