From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4B142D877A for ; Fri, 10 Apr 2026 08:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775810912; cv=none; b=YCFShYiGbe4WKPcNXEOMYJwaQjOOo7EGzYr8nkQPV6ShrZWX487Ftj86/6qyJih746E9Zq4aDTAHO2TbfNp61JgrlOEgMUccWR4qsNuMV3Vv0Be+cDsAC1Oz6C5NYRqa/IqLJAKEg6/0keRm6xw7eT6EgplE7EtyD3C33LPY24Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775810912; c=relaxed/simple; bh=YrYcxetUoCdKpTga/NiRsI7ssOntAeavqcg60Jz4W8I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tMxi2mlm7TbOrT3mVkCnzP5GG0rBVe7A3BM9cGQVaI6KAzoR+7nkEM5bDJo027egshMohkwv68+ZRxWc7wHadhqG34y3yRnxc+ouXXoIvERrKcqTN+c7nJhXfQNUhfTEQDtBSVOdBrJhShi4qAH+oPA9cYOk/wuR7xd1AU8T4jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=gTxBiQkq; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gTxBiQkq" Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A426D1BA; Fri, 10 Apr 2026 10:46:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1775810818; bh=YrYcxetUoCdKpTga/NiRsI7ssOntAeavqcg60Jz4W8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTxBiQkqFTOn1tKTQGsPD/tnVbiq28mC9oNTMmuI5R/qLizoZBCaeZ8ePbnL2hwKa wrajJJQYFMA6nZTbm9toWTvpAO0uPQgDqGKItTyPM50SWgWU4OrTs+SGIOO/ytE1vp ckx/G9AOY7XVk8Z+iijzg4LVLShLdzaEG1iVbPeY= Date: Fri, 10 Apr 2026 10:48:24 +0200 From: Jacopo Mondi To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 08/29] media: imx274: Remove redundant kernel-doc comments Message-ID: References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-9-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408153939.969381-9-sakari.ailus@linux.intel.com> Hi Sakari On Wed, Apr 08, 2026 at 06:39:17PM +0300, Sakari Ailus wrote: > Remove kernel-doc comments from regular callback functions. These > comments have no information value. > > Signed-off-by: Sakari Ailus This might be easy, but how is this related to metadata ? This is a 29 patch series that prepares for an 89 patch series. review time is not free, piling stuff over stuff is a recipe for making sure we'll never merge this. Anyway Reviewed-by: Jacopo Mondi > --- > drivers/media/i2c/imx274.c | 38 -------------------------------------- > 1 file changed, 38 deletions(-) > > diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c > index 8ec78b60bea6..241821572e03 100644 > --- a/drivers/media/i2c/imx274.c > +++ b/drivers/media/i2c/imx274.c > @@ -897,14 +897,6 @@ static int imx274_regulators_get(struct device *dev, struct stimx274 *imx274) > imx274->supplies); > } > > -/** > - * imx274_s_ctrl - This is used to set the imx274 V4L2 controls > - * @ctrl: V4L2 control to be set > - * > - * This function is used to set the V4L2 controls for the imx274 sensor. > - * > - * Return: 0 on success, errors otherwise > - */ > static int imx274_s_ctrl(struct v4l2_ctrl *ctrl) > { > struct v4l2_subdev *sd = ctrl_to_sd(ctrl); > @@ -1059,16 +1051,6 @@ static int __imx274_change_compose(struct stimx274 *imx274, > return 0; > } > > -/** > - * imx274_get_fmt - Get the pad format > - * @sd: Pointer to V4L2 Sub device structure > - * @sd_state: Pointer to sub device state structure > - * @fmt: Pointer to pad level media bus format > - * > - * This function is used to get the pad format information. > - * > - * Return: 0 on success > - */ > static int imx274_get_fmt(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *fmt) > @@ -1081,16 +1063,6 @@ static int imx274_get_fmt(struct v4l2_subdev *sd, > return 0; > } > > -/** > - * imx274_set_fmt - This is used to set the pad format > - * @sd: Pointer to V4L2 Sub device structure > - * @sd_state: Pointer to sub device state information structure > - * @format: Pointer to pad level media bus format > - * > - * This function is used to set the pad format. > - * > - * Return: 0 on success > - */ > static int imx274_set_fmt(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *format) > @@ -1423,16 +1395,6 @@ static void imx274_load_default(struct stimx274 *priv) > priv->ctrls.test_pattern->val = TEST_PATTERN_DISABLED; > } > > -/** > - * imx274_s_stream - It is used to start/stop the streaming. > - * @sd: V4L2 Sub device > - * @on: Flag (True / False) > - * > - * This function controls the start or stop of streaming for the > - * imx274 sensor. > - * > - * Return: 0 on success, errors otherwise > - */ > static int imx274_s_stream(struct v4l2_subdev *sd, int on) > { > struct stimx274 *imx274 = to_imx274(sd); > -- > 2.47.3 > >