From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35089305E19 for ; Fri, 10 Apr 2026 08:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775811267; cv=none; b=EhuBeYmwIZOXlSdcPrHzS22vgrSt0u/rl9m0dLEta8jwxaXclQTnVy132HqMhCwlK36uobloEyzNKKHl1YZFKt4N0Bz7SnwK74jb59MdM0+3kuyMe17ZoA1UUbnNL+RvF1dYJb/aXD4scO0SiSFiD2om7o7/bEhkVxm3YUHHTP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775811267; c=relaxed/simple; bh=LrcM1kWeSNOUi5HR84SYMEWAOfm/P63tiiupGcbNwsc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M7aOqGzb8A7KFHbRHHGQgcQk0QI5ZxW4tmwKyiNYckZ1wOxe3SDEbh1p65tlS4S8Kv57/FLEuHcb1uGjW7wlTr6uy3SdmaH7glFmQ92qOzGHialUKiyrGyPAbgpfy3BdSzHIVddmipdDjeIrVt+M+Wpg8pClGFH+adIu749k84U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=awvlqaSy; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="awvlqaSy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775811266; x=1807347266; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LrcM1kWeSNOUi5HR84SYMEWAOfm/P63tiiupGcbNwsc=; b=awvlqaSy8Bypy2STmY3PMt9WLxHUss2THtqmwe4KLdQA60YkPuZKAB1l NpGxko7N6BiSRX3y8fHHHs+DaomytCz77pscCOevOUma2rPyhFJGfufPZ 1KxnDIzKULNRwJI2tPkxRAOhvyQzEPsBKnTHWmW36o1YTbuubb0i2/IDa bGKQfCLvHRPLQ213rq+ZY7fQDcDSW1CVkPeQ60I7HCbS5PNqWMyCz/sSN 9pAnij4CJy6fRNbKSv5TsA64HFpvFj1A+SXH56Erkyt9JUCsDZTGkp+gM mSdwTAju7QjYHt/5TXtSCRhlT6g6+bqR0+3KSMJKU3Vc2iutdpA38IH/G w==; X-CSE-ConnectionGUID: 905KejQ+RFaXTQNF+AM2eg== X-CSE-MsgGUID: yhEiVurrQ1env/D69TwA7w== X-IronPort-AV: E=McAfee;i="6800,10657,11754"; a="77014553" X-IronPort-AV: E=Sophos;i="6.23,171,1770624000"; d="scan'208";a="77014553" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 01:54:26 -0700 X-CSE-ConnectionGUID: 7jwLxc/rR6aBTKW1gmVMsw== X-CSE-MsgGUID: CZQf8q4STRWVykjDqj/jZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,171,1770624000"; d="scan'208";a="224731006" Received: from dalessan-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.73]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 01:54:19 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id C2C95120F00; Fri, 10 Apr 2026 11:54:34 +0300 (EEST) Date: Fri, 10 Apr 2026 11:54:34 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Jacopo Mondi Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?iso-8859-1?Q?Andr=E9?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 08/29] media: imx274: Remove redundant kernel-doc comments Message-ID: References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-9-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Jacopo, Thank you for the review. On Fri, Apr 10, 2026 at 10:48:24AM +0200, Jacopo Mondi wrote: > Hi Sakari > > On Wed, Apr 08, 2026 at 06:39:17PM +0300, Sakari Ailus wrote: > > Remove kernel-doc comments from regular callback functions. These > > comments have no information value. > > > > Signed-off-by: Sakari Ailus > > This might be easy, but how is this related to metadata ? > This is a 29 patch series that prepares for an 89 patch series. Not directly, but not doing this now will require documenting the new arguments soon or we'd start getting warnings from the build. Writing documentation that shouldn't exist would be entirely non-productive work. > > review time is not free, piling stuff over stuff is a recipe for > making sure we'll never merge this. > > Anyway > Reviewed-by: Jacopo Mondi Thank you. -- Sakari Ailus