From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF6C73AB27C for ; Fri, 10 Apr 2026 09:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775811746; cv=none; b=F+OckTpLl3QUPaMCBvkZ0MWFd16G17BWzTRczVGYH2CRB8kiaeLIB+zs+ZbAZnLpe0IeXUy8eVnNTeFc3YAr8FSsKSGiG0V0P+b0wRmrfJBXXHEYiv9gSJuYwghWpFy6kfebjFjZleuoCP+eYFq3W9gLTpZiC2fPmwf+CYhJKMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775811746; c=relaxed/simple; bh=98/AxvG6TrIsB3uYPTAV8V6Gx7JT9SblQXn1H4lHVJs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tnR3Vmlcx3khLU9FzEZzfRDPSVm0lNLqW+g6p44MfJoQDRJepYavdsr+dQMGRpFLdpqFKNdMsxxCuoWr9AsXuNxCIz7+Nzphf/Qp5p3j+kZA1o7jdwtDvIk5Bhm2UTe/3gyPwV+vAvwixQ6YYw9Tu/9gmDa6J1x6MUvqA/QZmAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Vlg1640U; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Vlg1640U" Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F4E91BA; Fri, 10 Apr 2026 11:00:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1775811653; bh=98/AxvG6TrIsB3uYPTAV8V6Gx7JT9SblQXn1H4lHVJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vlg1640UBl6YdNPBp147D8lsjzRq6nPMVCy1jsajG7jCrZ0EZ6K1AJYa438X3ZMN2 FCf+6D+C+B2/lFNBTZCSFOop8ED4ffZXd9hjtXQI1Yi5j/yhDo991kjbEQyLNUQN90 AV6YE74C4Gu/Ww1zn4XKQC1xDoI/GmLVLyu0Q53o= Date: Fri, 10 Apr 2026 11:02:20 +0200 From: Jacopo Mondi To: Sakari Ailus Cc: Jacopo Mondi , linux-media@vger.kernel.org, hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 08/29] media: imx274: Remove redundant kernel-doc comments Message-ID: References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-9-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Sakari On Fri, Apr 10, 2026 at 11:54:34AM +0300, Sakari Ailus wrote: > Hi Jacopo, > > Thank you for the review. > > On Fri, Apr 10, 2026 at 10:48:24AM +0200, Jacopo Mondi wrote: > > Hi Sakari > > > > On Wed, Apr 08, 2026 at 06:39:17PM +0300, Sakari Ailus wrote: > > > Remove kernel-doc comments from regular callback functions. These > > > comments have no information value. > > > > > > Signed-off-by: Sakari Ailus > > > > This might be easy, but how is this related to metadata ? > > This is a 29 patch series that prepares for an 89 patch series. > > Not directly, but not doing this now will require documenting the new > arguments soon or we'd start getting warnings from the build. Writing > documentation that shouldn't exist would be entirely non-productive work. > I see. Thanks for explaining > > > > review time is not free, piling stuff over stuff is a recipe for > > making sure we'll never merge this. > > > > Anyway > > Reviewed-by: Jacopo Mondi > > Thank you. > > -- > Sakari Ailus