From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A073C5DB8 for ; Fri, 10 Apr 2026 09:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775812105; cv=none; b=Ci19K5lsqwPfAilyTo5AZuk87vfnjsln3PvqJnqAJZAbGDhLsaAf+oOB0CCPOjRxCFAkX5OHsvHGyuTk7E8A/mszB0MSFshaR6wK87Lq+qkSsmYK2FnohAkoyWR9Q0rChaZ4DH7bghYZsRhQARfB0Nh03LzQ8y1Ngxh7olRgpwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775812105; c=relaxed/simple; bh=8xrYudR4ehNBidPMTSQSZTtAMX98UgcG0gwrPOZI4i4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jHSb5d3oyOVuR5BCfz1/8bTSF1KbWKb3dKYe3gQkzUrtIlSu+5K9BIYqsWdGaPZmT0AgOlM/RVdC9jAVpy4+IjQr9GTEwTK4mn0N3VaWXDaNXQ3TTu50fYYjviEb/tGZaWw6nGngupMujP+kvQHKCeYCc6ge0r961Qjlyb9onF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=u6Y4XRqQ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u6Y4XRqQ" Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DF4ADE47; Fri, 10 Apr 2026 11:06:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1775812012; bh=8xrYudR4ehNBidPMTSQSZTtAMX98UgcG0gwrPOZI4i4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u6Y4XRqQPQifH2Rgp2zyqLwxXCfZ7XwFeFTob9Xin3NNhO7vPNNGyPO5PeXgOPKvw N6uo4DGKY+xJklZX1sR3yb9C3jyvaXWGjMIzo1lzrtMdvLaxxsRiwmwCZ2CPeeU/BQ 64CiCwGLtIHiXf8nJQ0x2xzQmQ5n4wRKr5djcO7Q= Date: Fri, 10 Apr 2026 11:08:17 +0200 From: Jacopo Mondi To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 12/29] media: ov9282: Remove redundant kernel-doc comments Message-ID: References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-13-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408153939.969381-13-sakari.ailus@linux.intel.com> Hi Sakari On Wed, Apr 08, 2026 at 06:39:21PM +0300, Sakari Ailus wrote: > Remove kernel-doc comments from regular callback functions. These comments > have no information value. > > Signed-off-by: Sakari Ailus Reviewed-by: Jacopo Mondi > --- > drivers/media/i2c/ov9282.c | 67 -------------------------------------- > 1 file changed, 67 deletions(-) > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > index 2167fb73ea41..5b6f897a74fc 100644 > --- a/drivers/media/i2c/ov9282.c > +++ b/drivers/media/i2c/ov9282.c > @@ -586,18 +586,6 @@ static u32 ov9282_flash_duration_to_us(struct ov9282 *ov9282, u32 value) > return DIV_ROUND_UP(value * frame_width, OV9282_STROBE_SPAN_FACTOR); > } > > -/** > - * ov9282_set_ctrl() - Set subdevice control > - * @ctrl: pointer to v4l2_ctrl structure > - * > - * Supported controls: > - * - V4L2_CID_VBLANK > - * - cluster controls: > - * - V4L2_CID_ANALOGUE_GAIN > - * - V4L2_CID_EXPOSURE > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl) > { > struct ov9282 *ov9282 = > @@ -704,14 +692,6 @@ static const struct v4l2_ctrl_ops ov9282_ctrl_ops = { > .try_ctrl = ov9282_try_ctrl, > }; > > -/** > - * ov9282_enum_mbus_code() - Enumerate V4L2 sub-device mbus codes > - * @sd: pointer to ov9282 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @code: V4L2 sub-device code enumeration need to be filled > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_enum_mbus_code(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_mbus_code_enum *code) > @@ -780,14 +760,6 @@ static void ov9282_fill_pad_format(struct ov9282 *ov9282, > fmt->format.xfer_func = V4L2_XFER_FUNC_NONE; > } > > -/** > - * ov9282_get_pad_format() - Get subdevice pad format > - * @sd: pointer to ov9282 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @fmt: V4L2 sub-device format need to be set > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_get_pad_format(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *fmt) > @@ -807,14 +779,6 @@ static int ov9282_get_pad_format(struct v4l2_subdev *sd, > return 0; > } > > -/** > - * ov9282_set_pad_format() - Set subdevice pad format > - * @sd: pointer to ov9282 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @fmt: V4L2 sub-device format need to be set > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_set_pad_format(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *fmt) > @@ -852,13 +816,6 @@ static int ov9282_set_pad_format(struct v4l2_subdev *sd, > return ret; > } > > -/** > - * ov9282_init_state() - Initialize sub-device state > - * @sd: pointer to ov9282 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_init_state(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state) > { > @@ -1157,12 +1114,6 @@ static const struct v4l2_subdev_internal_ops ov9282_internal_ops = { > .init_state = ov9282_init_state, > }; > > -/** > - * ov9282_power_on() - Sensor power on sequence > - * @dev: pointer to i2c device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_power_on(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > @@ -1206,12 +1157,6 @@ static int ov9282_power_on(struct device *dev) > return ret; > } > > -/** > - * ov9282_power_off() - Sensor power off sequence > - * @dev: pointer to i2c device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_power_off(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > @@ -1333,12 +1278,6 @@ static int ov9282_init_controls(struct ov9282 *ov9282) > return 0; > } > > -/** > - * ov9282_probe() - I2C client device binding > - * @client: pointer to i2c client device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int ov9282_probe(struct i2c_client *client) > { > struct ov9282 *ov9282; > @@ -1435,12 +1374,6 @@ static int ov9282_probe(struct i2c_client *client) > return ret; > } > > -/** > - * ov9282_remove() - I2C client device unbinding > - * @client: pointer to I2C client device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static void ov9282_remove(struct i2c_client *client) > { > struct v4l2_subdev *sd = i2c_get_clientdata(client); > -- > 2.47.3 > >