Re: [PATCH v4 02/29] media: imx219: Fix maximum frame length in lines

Laurent Pinchart
2026-04-16T13:56:39Z

On Wed, Apr 08, 2026 at 06:39:11PM +0300, Sakari Ailus wrote:
> The driver used the maximum frame length in lines value of 0xffff, but the
> maximum appears to be 0xfffe instead. Fix it.
>
> Fixes: 1283b3b8f82b ("media: i2c: Add driver for Sony IMX219 sensor")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
> drivers/media/i2c/imx219.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index cbd151d4af5f..89061dc1842d 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -72,7 +72,7 @@
>
> /* V_TIMING internal */
> #define IMX219_REG_FRM_LENGTH_A CCI_REG16(0x0160)
> -#define IMX219_FLL_MAX 0xffff
> +#define IMX219_FLL_MAX 0xfffe
> #define IMX219_VBLANK_MIN 32
> #define IMX219_REG_LINE_LENGTH_A CCI_REG16(0x0162)
> #define IMX219_LLP_MIN 0x0d78

--
Regards,

Laurent Pinchart