From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: Adrien Reynard <reynard.adrien.08@gmail.com>, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] docs: fix repeated word 'that' in userspace-api documentation
Date: Tue, 12 May 2026 09:12:36 +0200 [thread overview]
Message-ID: <ae008f16-acde-4ba9-8eff-6146bb0a931c@kernel.org> (raw)
In-Reply-To: <20260509143043.16403-1-reynard.adrien.08@gmail.com>
On 09/05/2026 16:30, Adrien Reynard wrote:
> Remove duplicated word 'that' in two places in the V4L2
> documentation files vidioc-g-ext-ctrls.rst and
> vidioc-subscribe-event.rst.
>
> Signed-off-by: Adrien Reynard <reynard.adrien.08@gmail.com>
> ---
> Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 2 +-
> .../userspace-api/media/v4l/vidioc-subscribe-event.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> index b8698b85bd80..8d5db414f8fa 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
> @@ -64,7 +64,7 @@ should re-allocate the memory to this new size and try again. For the
> string type it is possible that the same issue occurs again if the
> string has grown in the meantime. It is recommended to call
> :ref:`VIDIOC_QUERYCTRL` first and use
> -``maximum``\ +1 as the new ``size`` value. It is guaranteed that that is
> +``maximum``\ +1 as the new ``size`` value. It is guaranteed that is
> sufficient memory.
>
> N-dimensional arrays are set and retrieved row-by-row. You cannot set a
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-subscribe-event.rst b/Documentation/userspace-api/media/v4l/vidioc-subscribe-event.rst
> index a6fc3c5fe99d..845a90573e54 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-subscribe-event.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-subscribe-event.rst
> @@ -94,7 +94,7 @@ using the :ref:`VIDIOC_DQEVENT` ioctl.
> a V4L2_EVENT_CTRL to be sent back to that same filehandle.
> Normally such events are suppressed to prevent feedback loops
> where an application changes a control to a one value and then
> - another, and then receives an event telling it that that control
> + another, and then receives an event telling it that control
> has changed to the first value.
>
> Since it can't tell whether that event was caused by another
This is actually correct English:
https://englishcolege.com/is-that-that-grammatically-correct/#:~:text=Yes.,specific%20(as%20a%20pronoun).
Rejecting this patch.
Regards,
Hans
prev parent reply other threads:[~2026-05-12 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 16:37 [PATCH 1/5] docs: fix typos in userspace api documentation Adrien Reynard
2026-05-09 14:30 ` [PATCH v2 1/4] docs: fix repeated word 'that' in userspace-api documentation Adrien Reynard
2026-05-12 7:12 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae008f16-acde-4ba9-8eff-6146bb0a931c@kernel.org \
--to=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=reynard.adrien.08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox