Re: [PATCH v4 08/29] media: imx274: Remove redundant kernel-doc comments

Jacopo Mondi
2026-04-10T09:02:24Z

Hi Sakari

On Fri, Apr 10, 2026 at 11:54:34AM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> Thank you for the review.
>
> On Fri, Apr 10, 2026 at 10:48:24AM +0200, Jacopo Mondi wrote:
> > Hi Sakari
> >
> > On Wed, Apr 08, 2026 at 06:39:17PM +0300, Sakari Ailus wrote:
> > > Remove kernel-doc comments from regular callback functions. These
> > > comments have no information value.
> > >
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > This might be easy, but how is this related to metadata ?
> > This is a 29 patch series that prepares for an 89 patch series.
>
> Not directly, but not doing this now will require documenting the new
> arguments soon or we'd start getting warnings from the build. Writing
> documentation that shouldn't exist would be entirely non-productive work.
>

I see. Thanks for explaining

> >
> > review time is not free, piling stuff over stuff is a recipe for
> > making sure we'll never merge this.
> >
> > Anyway
> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
> Thank you.
>
> --
> Sakari Ailus