public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Yeh, Serin" <serin.yeh@intel.com>
Cc: Hans de Goede <johannes.goede@oss.qualcomm.com>,
	Kate Hsuan <hpa@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] media: i2c: imx471: Add Sony IMX471 image sensor driver
Date: Tue, 21 Apr 2026 12:26:43 +0300	[thread overview]
Message-ID: <aedC02xWo4x6nIpH@kekkonen.localdomain> (raw)
In-Reply-To: <DS0PR11MB7971EF4F2B0759AF0CD738D0F62F2@DS0PR11MB7971.namprd11.prod.outlook.com>

Hi Serin,

On Mon, Apr 20, 2026 at 07:23:19AM +0000, Yeh, Serin wrote:
> There are some reasons that the upside-down mirror/flip functions can't
> be submitted in the driver for upstream.
> 
> The version that I submitted for upstream is not included upside-down
> because the sensor has design limitations of mirror/flip.
> 
> Your version will occur incorrect bayer older on different platform.

I believe we'll need the flipping controls as the sensor is mounted upside
down in some systems. The rotation is provided to the user space but it
remains up to the user space to configure the sensor accordingly.

If there's a need to adjust the digital crop rectangle, we'll probably need
the common raw sensor model patches for that. That's what the driver in
fact appears to be doing but I have to admit I didn't check that bit very
carefully.

-- 
Kind regards,

Sakari Ailus

  parent reply	other threads:[~2026-04-21  9:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  8:32 [PATCH 0/2] Add Sony IMX471 camera sensor driver Kate Hsuan
2026-04-17  8:32 ` [PATCH 1/2] media: ipu-bridge: Add DMI information of Lenovo X9 to the image upside-down list Kate Hsuan
2026-04-17 10:37   ` Hans de Goede
2026-04-20  7:40     ` Kate Hsuan
2026-04-17  8:32 ` [PATCH 2/2] media: i2c: imx471: Add Sony IMX471 image sensor driver Kate Hsuan
2026-04-17 10:16   ` Hans de Goede
2026-04-20  4:05     ` Kate Hsuan
2026-04-20  6:48     ` Yeh, Serin
2026-04-20  7:23     ` Yeh, Serin
2026-04-20  8:59       ` Hans de Goede
2026-04-21  9:26       ` Sakari Ailus [this message]
2026-04-21  9:02     ` Sakari Ailus
2026-04-21  9:47       ` Hans de Goede
2026-04-21 20:05         ` Sakari Ailus
2026-04-28  3:08           ` Kate Hsuan
2026-04-28  8:49             ` Sakari Ailus
2026-04-21  9:23   ` Sakari Ailus
2026-04-28  4:05     ` Kate Hsuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aedC02xWo4x6nIpH@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=hpa@redhat.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=serin.yeh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox