public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Sunny Patel <nueralspacetech@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
Date: Tue, 21 Apr 2026 19:37:28 +0300	[thread overview]
Message-ID: <aeenyJ7u0o2wis4G@kekkonen.localdomain> (raw)
In-Reply-To: <20260409171705.8737-1-nueralspacetech@gmail.com>

Hi Sunny,

Thanks for the update.

Please always set the version of the patch if not the first.

On Thu, Apr 09, 2026 at 10:45:23PM +0530, Sunny Patel wrote:
> Removal is only required afte state->pads for stream_configs since
> state->pads only represents the static array so not required locking for
> it.
> 
> 

Extra newline.

> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.

Please use imperative when describing what the patch does.

> 
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---

Please describe changes across versions, at least from the previous one.

>  drivers/media/v4l2-core/v4l2-subdev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
>  	if (WARN_ON(!state))
>  		return NULL;
>  
> -	lockdep_assert_held(state->lock);
> -
>  	if (state->pads) {
>  		if (stream)
>  			return NULL;

-- 
Kind regards,

Sakari Ailus

      reply	other threads:[~2026-04-21 16:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-04 14:12 [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion Sunny Patel
2026-04-05 21:20 ` Laurent Pinchart
2026-04-06  9:58   ` Sunny Patel
2026-04-06 12:23     ` Laurent Pinchart
2026-04-07  5:39       ` [PATCH v2] media: v4l2-core: " Sunny Patel
2026-04-07  7:46         ` Laurent Pinchart
2026-04-09 17:15       ` [PATCH] media: v4l2-core: v4l2-subdev: " Sunny Patel
2026-04-21 16:37         ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeenyJ7u0o2wis4G@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nueralspacetech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox