Re: [PATCH v2 1/5] dt-bindings: leds: Document TI LM3560 Synchronous Boost Flash Driver

Svyatoslav Ryhel
2026-04-20T16:35:37Z

пн, 20 квіт. 2026 р. о 19:20 Conor Dooley <conor@kernel.org> пише:
>
> On Sun, Apr 19, 2026 at 12:34:08PM +0300, Svyatoslav Ryhel wrote:
> > Document TI LM3560 Synchronous Boost Flash Driver used for camera flash
> > LEDs.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > .../devicetree/bindings/leds/ti,lm3560.yaml | 131 ++++++++++++++++++
> > 1 file changed, 131 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/ti,lm3560.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/ti,lm3560.yaml b/Documentation/devicetree/bindings/leds/ti,lm3560.yaml
> > new file mode 100644
> > index 000000000000..c6c553ad23f9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/ti,lm3560.yaml
> > @@ -0,0 +1,131 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/ti,lm3560.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: TI LM3560 Synchronous Boost Flash Driver
> > +
> > +maintainers:
> > + - Svyatoslav Ryhel <clamor95@gmail.com>
> > +
> > +description:
> > + The LM3560 is a 2-MHz fixed frequency synchronous boost converter with two
> > + 1000-mA constant current drivers for high-current white LEDs. The dual high-
> > + side current sources allow for grounded cathode LED operation and can be
> > + tied together for providing flash currents at up to 2 A through a single LED.
> > + An adaptive regulation method ensures the current for each LED remains in
> > + regulation and maximizes efficiency.
> > +
> > +allOf:
> > + - $ref: /schemas/leds/common.yaml
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,lm3559
> > + - ti,lm3560
>
> What differentiates these devices to the point that fallback compatibles
> are not suitable?
>

noted

> Cheers,
> Conor.
>
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 0
> > +
> > + enable-gpios:
> > + description: GPIO connected to the HWEN pin.
> > + maxItems: 1
> > +
> > + vin-supply:
> > + description: Supply connected to the IN line.
> > +
> > + flash-max-timeout-us:
> > + minimum: 32000
> > + maximum: 1024000
> > + default: 32000
> > +
> > + ti,peak-current-microamp:
> > + description:
> > + The LM3560 features 4 selectable current limits 1.6A, 2.3A, 3A, and 3.6A.
> > + When the current limit is reached, the LM3560 stops switching for the
> > + remainder of the switching cycle.
> > + enum: [16000000, 23000000, 30000000, 36000000]
> > + default: 16000000
> > +
> > +patternProperties:
> > + '^led@[01]$':
> > + description: LED control bank nodes.
> > + $ref: /schemas/leds/common.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + reg:
> > + description: Control bank selection (0 = bank A, 1 = bank B).
> > + maximum: 1
> > +
> > + flash-max-microamp:
> > + minimum: 62500
> > + maximum: 1000000
> > +
> > + led-max-microamp:
> > + minimum: 31250
> > + maximum: 250000
> > +
> > + required:
> > + - reg
> > + - flash-max-microamp
> > + - led-max-microamp
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#address-cells'
> > + - '#size-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + led-controller@53 {
> > + compatible = "ti,lm3560";
> > + reg = <0x53>;
> > +
> > + enable-gpios = <&gpio 28 GPIO_ACTIVE_HIGH>;
> > + vin-supply = <&vdd_3v3_sys>;
> > +
> > + flash-max-timeout-us = <1024000>;
> > + ti,peak-current-microamp = <16000000>;
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + led@0 {
> > + reg = <0>;
> > +
> > + label = "white::flash";
> > + linux,default-trigger = "flash";
> > +
> > + flash-max-microamp = <562500>;
> > + led-max-microamp = <156250>;
> > + };
> > +
> > + led@1 {
> > + reg = <1>;
> > +
> > + label = "yellow::flash";
> > + linux,default-trigger = "flash";
> > +
> > + flash-max-microamp = <562500>;
> > + led-max-microamp = <156250>;
> > + };
> > + };
> > + };
> > --
> > 2.51.0
> >