Re: [PATCH v4 08/15] remoteproc: qcom_wcnss: Switch to generic PAS TZ APIs

Mukesh Ojha
2026-04-29T13:43:49Z

On Mon, Apr 27, 2026 at 03:25:56PM +0530, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
> Switch qcom_wcnss client driver over to generic PAS TZ APIs. Generic PAS
> TZ service allows to support multiple TZ implementation backends like QTEE
> based SCM PAS service, OP-TEE based PAS service and any further future TZ
> backend service.
>
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> ---
> drivers/remoteproc/qcom_wcnss.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c
> index 4add9037dbd5..0dbdd18ab3dd 100644
> --- a/drivers/remoteproc/qcom_wcnss.c
> +++ b/drivers/remoteproc/qcom_wcnss.c
> @@ -19,7 +19,7 @@
> #include <linux/platform_device.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_runtime.h>
> -#include <linux/firmware/qcom/qcom_scm.h>
> +#include <linux/firmware/qcom/qcom_pas.h>
> #include <linux/regulator/consumer.h>
> #include <linux/remoteproc.h>
> #include <linux/soc/qcom/mdt_loader.h>
> @@ -257,7 +257,7 @@ static int wcnss_start(struct rproc *rproc)
> wcnss_indicate_nv_download(wcnss);
> wcnss_configure_iris(wcnss);
>
> - ret = qcom_scm_pas_auth_and_reset(WCNSS_PAS_ID);
> + ret = qcom_pas_auth_and_reset(WCNSS_PAS_ID);
> if (ret) {
> dev_err(wcnss->dev,
> "failed to authenticate image and release reset\n");
> @@ -269,7 +269,7 @@ static int wcnss_start(struct rproc *rproc)
> if (wcnss->ready_irq > 0 && ret == 0) {
> /* We have a ready_irq, but it didn't fire in time. */
> dev_err(wcnss->dev, "start timed out\n");
> - qcom_scm_pas_shutdown(WCNSS_PAS_ID);
> + qcom_pas_shutdown(WCNSS_PAS_ID);
> ret = -ETIMEDOUT;
> goto disable_iris;
> }
> @@ -311,7 +311,7 @@ static int wcnss_stop(struct rproc *rproc)
> 0);
> }
>
> - ret = qcom_scm_pas_shutdown(WCNSS_PAS_ID);
> + ret = qcom_pas_shutdown(WCNSS_PAS_ID);
> if (ret)
> dev_err(wcnss->dev, "failed to shutdown: %d\n", ret);
>
> @@ -557,10 +557,10 @@ static int wcnss_probe(struct platform_device *pdev)
>
> data = of_device_get_match_data(&pdev->dev);
>
> - if (!qcom_scm_is_available())
> + if (!qcom_pas_is_available())
> return -EPROBE_DEFER;
>
> - if (!qcom_scm_pas_supported(WCNSS_PAS_ID)) {
> + if (!qcom_pas_supported(WCNSS_PAS_ID)) {
> dev_err(&pdev->dev, "PAS is not available for WCNSS\n");
> return -ENXIO;
> }

Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

> --
> 2.51.0
>

--
-Mukesh Ojha