From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Shirin Kaul <shirin.kaul11@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: atomisp: isp: xnr 3.0 fix whitespace issue
Date: Mon, 4 May 2026 11:45:56 +0300 [thread overview]
Message-ID: <afhcxJeQ19nXKvAo@ashevche-desk.local> (raw)
In-Reply-To: <20260503105445.45058-1-shirin.kaul11@gmail.com>
On Sun, May 03, 2026 at 10:54:45AM +0000, Shirin Kaul wrote:
> Fix spaces by replacing them with tabs in function calls to comply
> with kernel coding style with checkpatch.pl.
Subject is wrong. The patch doesn't cover things outside the single file.
The patch does two things (has to be split). Also patch doesn't anyhow
rely on the preexisted changes that were submitted to the mailing list
(that cover much more that this one).
> v2:
> - Added trailing commas in arrays
> - Fixed indentation
We have special place for the changelog and comments...
> Signed-off-by: Shirin Kaul <shirin.kaul11@gmail.com>
> ---
...somewhere here.
> .../kernels/xnr/xnr_3.0/ia_css_xnr3.host.c | 29 +++++++++----------
> 1 file changed, 13 insertions(+), 16 deletions(-)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-04 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 8:25 [PATCH] staging: atomisp: isp: xnr 3.0 fix whitespace issue Shirin Kaul
2026-05-02 8:33 ` Andy Shevchenko
2026-05-03 10:54 ` [PATCH v2] " Shirin Kaul
2026-05-04 8:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afhcxJeQ19nXKvAo@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shirin.kaul11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox