From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Martin Hecht <mhecht73@gmail.com>
Cc: martin.hecht@avnet.eu, michael.roeder@avnet.eu,
Tommaso Merciai <tomm.merciai@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Fix: correct typo in alvium_set_ctrl_auto_exposure
Date: Tue, 5 May 2026 10:01:22 +0300 [thread overview]
Message-ID: <afmVwrZx_Gp1ShO7@kekkonen.localdomain> (raw)
In-Reply-To: <20260504160114.282024-1-mhecht73@gmail.com>
Hi Martin,
On Mon, May 04, 2026 at 06:01:10PM +0200, Martin Hecht wrote:
> write value for auto-exposure into register REG_BCRM_EXPOSURE_AUTO_RW
> instead of wrong register REG_BCRM_WHITE_BALANCE_AUTO_RW.
>
> Signed-off-by: Martin Hecht <mhecht73@gmail.com>
> ---
> drivers/media/i2c/alvium-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c
> index 955b7072a560..b62b45a4f2fc 100644
> --- a/drivers/media/i2c/alvium-csi2.c
> +++ b/drivers/media/i2c/alvium-csi2.c
> @@ -1290,7 +1290,7 @@ static int alvium_set_ctrl_auto_exposure(struct alvium_dev *alvium, bool on)
> struct device *dev = &alvium->i2c_client->dev;
> int ret;
>
> - ret = alvium_write_hshake(alvium, REG_BCRM_WHITE_BALANCE_AUTO_RW,
> + ret = alvium_write_hshake(alvium, REG_BCRM_EXPOSURE_AUTO_RW,
Should this also be backported? Could you provide a Fixes: tag?
> on ? 0x02 : 0x00);
> if (ret) {
> dev_err(dev, "Fail to set autoexposure reg\n");
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2026-05-05 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 16:01 [PATCH v1] Fix: correct typo in alvium_set_ctrl_auto_exposure Martin Hecht
2026-05-05 7:01 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afmVwrZx_Gp1ShO7@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.hecht@avnet.eu \
--cc=mchehab@kernel.org \
--cc=mhecht73@gmail.com \
--cc=michael.roeder@avnet.eu \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox