Re: media: pci: Use PCI_DEVICE macros and drop zeros from pci_device_id arrays

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]

Hello,

On Wed, May 06, 2026 at 03:07:33PM -0700, Patchwork Integration wrote:
> Dear Uwe Kleine-König (The Capable Hub):
> 
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:
> 
> # Test media-patchstyle:./0001-media-pci-Use-PCI_DEVICE-macros-and-drop-zeros-from-.patch media style
> ERROR: ./0001-media-pci-Use-PCI_DEVICE-macros-and-drop-zeros-from-.patch: Missing committer Ricardo Ribalda <ribalda@chromium.org> Signed-off-by

I don't understand that one. Ricardo has nothing to do with creating and
applying the patch so far, so why should there be an S-o-b by them?

> # Test checkpatch:./0001-media-pci-Use-PCI_DEVICE-macros-and-drop-zeros-from-.patch checkpatch
> CHECK: No space is necessary after a cast
> #2473: FILE: drivers/media/pci/saa7146/hexium_gemini.c:365:
> +.driver_data = (unsigned long) &hexium_gemini_4bnc,
> 
> CHECK: No space is necessary after a cast
> #2486: FILE: drivers/media/pci/saa7146/hexium_gemini.c:369:
> +.driver_data = (unsigned long) &hexium_gemini_dual_4bnc,
> 
> CHECK: No space is necessary after a cast
> #2524: FILE: drivers/media/pci/saa7146/hexium_orion.c:429:
> +.driver_data = (unsigned long) &hexium_hv_pci6,
> 
> CHECK: No space is necessary after a cast
> #2527: FILE: drivers/media/pci/saa7146/hexium_orion.c:432:
> +.driver_data = (unsigned long) &hexium_orion_1svhs_3bnc,
> 
> CHECK: No space is necessary after a cast
> #2530: FILE: drivers/media/pci/saa7146/hexium_orion.c:435:
> +.driver_data = (unsigned long) &hexium_orion_4bnc,

I didn't introduce these, but can cleanup that en passant. IMHO it's ok
to leave it as is because I will touch these lines in the (hopefully
near) future anyhow to make them

	.driver_data_ptr = &hexium_orion_4bnc,

.

Please tell me about your expectations here.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]