From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Melih Emik <melihemik@noirlang.tr>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] atomisp: replace dbg_func parameter with dynamic debug
Date: Tue, 12 May 2026 22:12:33 +0300 [thread overview]
Message-ID: <agN7odzJiulkNckJ@ashevche-desk.local> (raw)
In-Reply-To: <20260512180958.18098-1-melihemik@noirlang.tr>
On Tue, May 12, 2026 at 09:09:58PM +0300, Melih Emik wrote:
> The dbg_func module parameter in atomisp_v4l2.c toggles the CSS
> debug_print callback through a writable module parameter. Removing only
> the parameter drops the runtime switch that users had through sysfs.
>
> Keep the debug path available at runtime by routing CSS debug output
> through dynamic debug instead. The callback remains installed, but its
> output is controlled by the dynamic debug callsite. CSS error output
> continues to use vprintk().
>
> Remove the obsolete parameter, its global state and the unused get/set
> helpers.
Okay, this is the move to the right direction (however we leave dbg_level for
whatever it means).
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-12 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 19:32 [PATCH] atomisp: remove unused module parameter dbg_func Melih Emik
2026-05-12 4:26 ` Andy Shevchenko
2026-05-12 18:09 ` [PATCH v2] atomisp: replace dbg_func parameter with dynamic debug Melih Emik
2026-05-12 19:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agN7odzJiulkNckJ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=melihemik@noirlang.tr \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox