Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Arun T <arun.t@intel.com>
Cc: johannes.goede@oss.qualcomm.com, arec.kao@intel.com,
	ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com,
	platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, mehdi.djait@intel.com
Subject: Re: [PATCH v10 1/2] platform/x86: int3472: Add TPS68470 board data for Intel nvl
Date: Wed, 13 May 2026 15:24:39 +0300	[thread overview]
Message-ID: <agRth_6pb8zjVgIF@kekkonen.localdomain> (raw)
In-Reply-To: <20260408104510.392906-2-arun.t@intel.com>

Hi Arun,

On Wed, Apr 08, 2026 at 04:15:06PM +0530, Arun T wrote:
> The Intel NVL platform uses IPU8 is powered by a TPS68470 PMIC,requiring board
> data to configure the GPIOs and regulators for proper camera sensor operation.

Please rewrap this -- checkpatch.pl would have warned about it.

> 
> Signed-off-by: Arun T <arun.t@intel.com>
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

...

> @@ -336,10 +418,27 @@ static const struct property_entry msi_p14_ai_evo_gpio_props[] = {
>  	{ }
>  };
>  
> +static const struct property_entry intel_nvl_gpio_props[] = {
> +	PROPERTY_ENTRY_BOOL("daisy-chain-enable"),

After Antti's patches this no longer applies.

Can you rebase the set on my int3472 branch
<URL:https://gitlab.freedesktop.org/linux-media/users/sailus>, please?

With this, I think it'd make sense to rename msi_prestige_ai_evo_gpio_props
and msi_prestige_ai_evo_tps68470_gpio_swnode as
int3472_tps68470_daisy_chain_gpio_swnode and
int3472_tps68470_daisy_chain_gpio_props, respectively, and use it here for
NVL as well.

Can you add a patch for that, to precede these two?

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-05-13 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 10:45 [PATCH v10 0/2] Add TPS68470 power supply support for ov13b10 sensor Arun T
2026-04-08 10:45 ` [PATCH v10 1/2] platform/x86: int3472: Add TPS68470 board data for Intel nvl Arun T
2026-05-13 12:24   ` Sakari Ailus [this message]
2026-04-08 10:45 ` [PATCH v10 2/2] media: ov13b10: Support multiple regulators Arun T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agRth_6pb8zjVgIF@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=arec.kao@intel.com \
    --cc=arun.t@intel.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mehdi.djait@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox