Re: [v1] media: Use named initializers for arrays of i2c_device_data

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 4471 bytes --]

Hello,

On Fri, May 15, 2026 at 11:24:38AM -0700, Patchwork Integration wrote:
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:

I wonder about the Media CI robot testing iio and hwmon patches. What is
their source? (Hmm, I guess that's because I forgot to remove the
prerequisite-patch-id lines from the patch.)

> # Test checkpatch:./0001-scsi-mvsas-Don-t-emit-__LINE__-in-debug-messages.patch checkpatch
> WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
> #36: FILE: drivers/scsi/mvsas/mv_sas.h:38:
> +printk(KERN_DEBUG "%s: " fmt, __func__, ## arg)

This issue was present already before, but yes, that could be addressed
in a separate patch set.

> total: 0 errors, 1 warnings, 0 checks, 13 lines checked
> 
> # Test checkpatch:./0007-iio-Initialize-i2c_device_id-arrays-using-member-nam.patch checkpatch
> WARNING: line length of 102 exceeds 100 columns
> #573: FILE: drivers/iio/chemical/atlas-ezo-sensor.c:189:
> +{ .name = "atlas-co2-ezo", .driver_data = (kernel_ulong_t)&atlas_ezo_devices[ATLAS_CO2_EZO] },
> 
> WARNING: line length of 102 exceeds 100 columns
> #575: FILE: drivers/iio/chemical/atlas-ezo-sensor.c:191:
> +{ .name = "atlas-hum-ezo", .driver_data = (kernel_ulong_t)&atlas_ezo_devices[ATLAS_HUM_EZO] },

Yeah, these are unfortunate, but I don't want to add line breaks to the
array. Once i2c_device_id got the union that I want to add to it, I will
do

-	{ .name = "atlas-hum-ezo", .driver_data = (kernel_ulong_t)&atlas_ezo_devices[ATLAS_HUM_EZO] },
+	{ .name = "atlas-hum-ezo", .driver_data_ptr = &atlas_ezo_devices[ATLAS_HUM_EZO] },

shorten the line again below the 100 char limit.

> total: 0 errors, 2 warnings, 0 checks, 1372 lines checked
> 
> # Test checkpatch:./0009-hwmon-pmbus-mp2869-Drop-unjustified-__maybe_unused.patch checkpatch
> ERROR: missing sentinel in ID array
> #27: FILE: drivers/hwmon/pmbus/mp2869.c:643:
> +static const struct of_device_id mp2869_of_match[] = {
>  { .compatible = "XXXXXXXXXX" },
>  { .compatible = "XXXXXXXXXXX" },
>  { .compatible = "XXXXXXXXXXX" },

This is a false positive, the sentinel is missing in the context of the
patch, but it's there in the source file.

> total: 1 errors, 0 warnings, 0 checks, 8 lines checked
> 
> # Test checkpatch:./0012-ASoC-Use-named-initializers-for-arrays-of-i2c_device.patch checkpatch
> WARNING: please, no spaces at the start of a line
> #1251: FILE: sound/soc/codecs/max98088.c:1725:
> +       { .name = "max98088", .driver_data = MAX98088 },$
> 
> WARNING: please, no spaces at the start of a line
> #1252: FILE: sound/soc/codecs/max98088.c:1726:
> +       { .name = "max98089", .driver_data = MAX98089 },$

Huh, indeed, that needs fixing (though my patch didn't introduce the
issue). I already forwarded that info to the thread where this patch is
discussed.

> total: 0 errors, 2 warnings, 0 checks, 1982 lines checked
> 
> # Test checkpatch:./0013-mfd-Use-named-initializers-for-arrays-of-i2c_device_.patch checkpatch
> WARNING: please, no spaces at the start of a line
> #1005: FILE: drivers/mfd/tps65910.c:521:
> +       { .name = "tps65910", .driver_data = TPS65910 },$
> 
> WARNING: please, no spaces at the start of a line
> #1006: FILE: drivers/mfd/tps65910.c:522:
> +       { .name = "tps65911", .driver_data = TPS65911 },$
> 
> WARNING: line length of 101 exceeds 100 columns
> #1046: FILE: drivers/mfd/twl-core.c:933:
> +{ .name = "tps65930", .driver_data = TPS_SUBSET },/* fewer LDOs and DACs; no charger */
> 
> WARNING: line length of 101 exceeds 100 columns
> #1047: FILE: drivers/mfd/twl-core.c:934:
> +{ .name = "tps65920", .driver_data = TPS_SUBSET },/* fewer LDOs; no codec or charger */

ditto

> WARNING: Block comments use * on subsequent lines
> #1049: FILE: drivers/mfd/twl-core.c:936:
> +{ .name = "tps65921", .driver_data = TPS_SUBSET },/* fewer LDOs; no codec, no LED
> +   and vibrator. Charger in USB module*/
> 
> WARNING: Block comments use a trailing */ on a separate line
> #1049: FILE: drivers/mfd/twl-core.c:936:
> +   and vibrator. Charger in USB module*/

I don't know how to fix that (it wasn't introduced in my patch), would
require a complete reformatting I guess, not sure I want to make that
part of my quest.
 
> [...]

the remaining issues are similar and addressed in the same way.

Thanks
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]