From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A7B4379C43; Wed, 3 Jun 2026 10:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780483814; cv=none; b=K206/fZ/xmEXN4X+gBzqBxqyaFS6Fqcp8fpx7DTRPc/ACPpqEDxPOj8uKMxIA20pSRlRteffnZnE9z3kMsZXEPTp44ooNHAdFxVJ5HVsVpHAtECPVmDoeJTu/LhpDrz3Bs4IGxwmI0ysOixjCN+DMCplmDmpWiPRilmKimhfKc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780483814; c=relaxed/simple; bh=RCDXZjVqAfdAYLsK7R4LkI0bmR5BRYLxW0TZHHtJg7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KrnY7qJBomwL0SSoI7hMYjRSroeP8bFxVGHGqbDDlh2gzTYUg5Oz5ziv/04G0BwUL7OVxJiLVHqreihW4nMdVA4AYcxFbrdtBQpI2MOdN0VJy88Hm98ErPJ/phi7cPpsKsH/9hsijlViA78PavNb4BkiFb6Z8W0Esnzt9Z7e/Ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=rV2F5LNx; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rV2F5LNx" Received: from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2025F664; Wed, 3 Jun 2026 12:49:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1780483788; bh=RCDXZjVqAfdAYLsK7R4LkI0bmR5BRYLxW0TZHHtJg7g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rV2F5LNx3xu+vLrZSgcWyEfw47H0aQBJTroDbqwMAozYTT0sxFtKIrmaDZCV8CHLz fUK+mMsYm4tRLpFIxTwVGzFjevfgf4BCoSEDwS+2NaR7nat4DsUZjoeCJYBTOAqk2V eizcF4HPhKrvIXklN5jUT6TEVXG3ZkVLjAWPKBkQ= Date: Wed, 3 Jun 2026 12:50:08 +0200 From: Jacopo Mondi To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Jacopo Mondi , Jai Luthra , Mauro Carvalho Chehab , Kuninori Morimoto , Laurent Pinchart , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jai Luthra Subject: Re: [PATCH v9 02/13] media: uapi: Add extensible param and stats blocks for RPPX1 Message-ID: References: <20260516211320.3041412-1-niklas.soderlund+renesas@ragnatech.se> <20260516211320.3041412-3-niklas.soderlund+renesas@ragnatech.se> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260516211320.3041412-3-niklas.soderlund+renesas@ragnatech.se> Hi Niklas On Sat, May 16, 2026 at 11:13:09PM +0200, Niklas Söderlund wrote: > From: Jai Luthra > > Add the scaffolding for the parameters and statistics buffers for > Dreamchip RPPX1. The parameters for each ISP function block will be > added together with the logic for it. > > In addition to the scaffolding add a common struct that describes the > measurement window. This struct is not specific to any block and will > used by many of them. > > Signed-off-by: Jai Luthra > [Niklas: Commit message] > Signed-off-by: Niklas Söderlund > --- > .../uapi/linux/media/dreamchip/rppx1-config.h | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 include/uapi/linux/media/dreamchip/rppx1-config.h > > diff --git a/include/uapi/linux/media/dreamchip/rppx1-config.h b/include/uapi/linux/media/dreamchip/rppx1-config.h > new file mode 100644 > index 000000000000..26627be6f483 > --- /dev/null > +++ b/include/uapi/linux/media/dreamchip/rppx1-config.h > @@ -0,0 +1,66 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > +/* > + * Dreamchip RPP-X1 ISP Driver - Userspace API > + * > + * Copyright (C) 2026 Renesas Electronics Corp. > + * Copyright (C) 2026 Ideas on Board Oy > + * Copyright (C) 2026 Ragnatech AB > + */ > + > +#ifndef __UAPI_RPP_X1_CONFIG_H > +#define __UAPI_RPP_X1_CONFIG_H > + > +#include v4l2-isp.h already includes this one > +#include > + > +/** > + * struct rppx1_window - Measurement window > + * > + * RPP-X1 measurement window. Different blocks use a window or multiple > + * windows for measurement purposes. This defines a common type for all of > + * them. The number of relevant bits depends on the block where the window is > + * used and is specified in the per-block description > + * > + * @h_offs: horizontal offset from the left of the frame in pixels > + * @v_offs: vertical offset from the top of the frame in pixels > + * @h_size: horizontal size of the window in pixels > + * @v_size: vertical size of the window in pixels > + */ > +struct rppx1_window { > + __u16 h_offs; > + __u16 v_offs; > + __u16 h_size; > + __u16 v_size; > +}; > + > +/* --------------------------------------------------------------------------- > + * Parameter Structures > + * > + * Native RPP-X1 precision. Fields use __u32 where the hardware provides > + * wider-than-8-bit results. > + */ > + > +/** > + * RPPX1_PARAMS_MAX_SIZE - Maximum size of all RPP-X1 parameter blocks > + * > + * Some types are reported twice as the same block might be instantiated in > + * multiple pipes. > + */ > +#define RPPX1_PARAMS_MAX_SIZE 0 > + > +/* --------------------------------------------------------------------------- > + * Statistics Structures > + * > + * Native RPP-X1 precision. Fields use __u32 where the hardware provides > + * wider-than-8-bit results. > + */ > + > +/** > + * RPPX1_STATS_MAX_SIZE - Maximum size of all RPP-X1 statistics > + * > + * Some types are reported twice as the same block might be instantiated in > + * multiple pipes. > + */ > +#define RPPX1_STATS_MAX_SIZE 0 > + > +#endif /* __UAPI_RPP_X1_CONFIG_H */ Reviewed-by: Jacopo Mondi Thanks j > -- > 2.54.0 >