From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1C543B47F3 for ; Mon, 8 Jun 2026 13:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780926296; cv=none; b=BQQrV2swo6zvdH/4RhxqhEHOB7PEA5v0I1gvRi20uc7Hv0ehP8irjYUg+RxWhpJ46V414JOWSMdM/BW1s/T19WX9Dmrsd1LejsB3i+MT9cqewDYku8buVT7TDBjYFKCIH1y6gBUBAdPvqzXAFHh105XmuCzp6qY/mVx3DgOS45Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780926296; c=relaxed/simple; bh=w5+gjpol14uAbICR7Csqc8uwTr6tw023T0gYtJ3ZOJU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j47aJ9V8tpV1YKx5EAynCKKIKuqwJuX/Ht4lCyHhheKOne4W1IyqE+NhZJ3Mp/wCpRsHjFnsu73chkOSZOQTs4/it+wlJeCwhHMXrOxG+XT62h8vUkUtS+abxuhmlTbkp8hWotDnk9o6bJybyrzDAgIXQSTmN9pVrsLsMIh/3zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CpDXPjVP; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CpDXPjVP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780926295; x=1812462295; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=w5+gjpol14uAbICR7Csqc8uwTr6tw023T0gYtJ3ZOJU=; b=CpDXPjVPNCyxHrb0xXBWUVCr86hXIL4k7GcavQ2l+QlENMPAeMKnhpkm 243dZ/i8YgM/9cgMRXSmCQO3JRt71XTwFIArLIdJXI5KXFn+LEWkKta1U R8opi1CK26yYrTwXIrumtvLPsQljPbCl32z4tqy6/q7p87i98G2lm/APc 7UiJP4bwat4CxsmKLjq5wqNhUveY+OV4oCt14wziLZoEJnPWK6ZnXcjdO LfsySvun9uf/v2xI1HcVd4bfjX5lfthdr6UuXBUhPgrSE/azWUCK6lx6U Q+4k3knxbhaXql9LQolf9MZY9w2m+N2mf8seWRYAX7xsc2x9mXQGssMRm A==; X-CSE-ConnectionGUID: qU7MISEoSZ+SSkGYviLHQQ== X-CSE-MsgGUID: Mhnxbm1wS7O9zbveeYeu3A== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="84232836" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="84232836" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 06:44:54 -0700 X-CSE-ConnectionGUID: FcQypJBPQcC0AXg1FZMPHA== X-CSE-MsgGUID: fOTviHrbRcamdUq/yztsBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="243111325" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.127]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 06:44:47 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id E96D4121C67; Mon, 08 Jun 2026 16:44:44 +0300 (EEST) Date: Mon, 8 Jun 2026 16:44:44 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Laurent Pinchart Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?iso-8859-1?Q?Andr=E9?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v5 03/10] media: imx219: Account rate_factor in setting upper exposure limit Message-ID: References: <20260607215356.842932-1-sakari.ailus@linux.intel.com> <20260607215356.842932-4-sakari.ailus@linux.intel.com> <20260608090625.GA772117@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608090625.GA772117@killaraus.ideasonboard.com> Hi Laurent, On Mon, Jun 08, 2026 at 12:06:25PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Mon, Jun 08, 2026 at 12:53:49AM +0300, Sakari Ailus wrote: > > The rate_factor multiplier is used to multiply a few values in the > > sensor's timing configuration and the exposure time is one of them. This > > also needs to be taken into account in exposure time margin: multiply it > > by rate_factor so that sensor's exposure time margin is respected. > > > > Fixes: f513997119f4 ("media: i2c: imx219: Scale the pixel rate for analog binning") > > Cc: stable@vger.kernel.org > > Signed-off-by: Sakari Ailus > > --- > > drivers/media/i2c/imx219.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > > index d8fe7db18b6c..e681f80f9e3e 100644 > > --- a/drivers/media/i2c/imx219.c > > +++ b/drivers/media/i2c/imx219.c > > @@ -451,7 +451,8 @@ static int imx219_set_ctrl(struct v4l2_ctrl *ctrl) > > int exposure_max, exposure_def; > > > > /* Update max exposure while meeting expected vblanking */ > > - exposure_max = format->height + ctrl->val - IMX219_EXPOSURE_OFFSET; > > + exposure_max = format->height + ctrl->val - > > + IMX219_EXPOSURE_OFFSET * rate_factor; > > I'm not sure if this is quite right, I need some more time to research. > Regardless of that, isn't the same change also needed in > imx219_set_pad_format() ? Indeed. I'll take that into account in v6. Controls are initialised for non-binned default mode so that part is ok. > > > exposure_def = (exposure_max < IMX219_EXPOSURE_DEFAULT) ? > > exposure_max : IMX219_EXPOSURE_DEFAULT; > > ret = __v4l2_ctrl_modify_range(imx219->exposure, > -- Regards, Sakari Ailus