From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Xiaolei Wang <xiaolei.wang@windriver.com>,
Tarang Raval <tarang.raval@siliconsignals.io>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description
Date: Wed, 10 Jun 2026 18:30:51 +0200 [thread overview]
Message-ID: <aimQ3ln0y0jxMWT3@zed> (raw)
In-Reply-To: <20260610-media-ci-7-2-v1-2-3c61a482a44e@chromium.org>
Hi Ricardo
On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> The variable has been previously removed but not its kerneldoc.
>
> Also remove the leftover reference to state in the description of qlock.
>
> This patch fixes the following warning:
>
> Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> Excess struct member 'state' description in 'rzg2l_cru_dev'
upsie
indeed!
>
> Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
My only question is if this qualifies for stable or not...
Honestly, I would drop the Fixes tag here
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> index 5bf334e173d2..b426bc7898bf 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
> * @scratch_phys: physical address of the scratch buffer
> *
> * @qlock: protects @queue_buf, @buf_list, @sequence
> - * @state
> * @queue_buf: Keeps track of buffers given to HW slot
> * @buf_list: list of queued buffers
> * @sequence: V4L2 buffers sequence number
> - * @state: keeps track of operation state
> *
> * @format: active V4L2 pixel format
> */
>
> --
> 2.54.0.1099.g489fc7bff1-goog
>
next prev parent reply other threads:[~2026-06-10 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 16:20 [PATCH 0/3] media: Media-CI patches for kernel 7.2 Ricardo Ribalda
2026-06-10 16:20 ` [PATCH 1/3] media: ov9282: Remove unused kerneldoc description Ricardo Ribalda
2026-06-10 16:27 ` Dan Scally
2026-06-10 20:18 ` Laurent Pinchart
2026-06-10 16:20 ` [PATCH 2/3] media: rzg2l-cru: " Ricardo Ribalda
2026-06-10 16:22 ` Dan Scally
2026-06-10 16:30 ` Jacopo Mondi [this message]
2026-06-10 16:35 ` Ricardo Ribalda
2026-06-10 16:47 ` Jacopo Mondi
2026-06-10 20:21 ` Laurent Pinchart
2026-06-10 16:20 ` [PATCH 3/3] media: mc-entity: Add missing kerneldoc Ricardo Ribalda
2026-06-10 16:27 ` Dan Scally
2026-06-10 20:22 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aimQ3ln0y0jxMWT3@zed \
--to=jacopo.mondi@ideasonboard.com \
--cc=dan.scally@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tarang.raval@siliconsignals.io \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox