From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E844D2E8B98; Wed, 10 Jun 2026 16:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110076; cv=none; b=IQpM+z8a3D/w3TyWXj49Klw/1qXaDc8zi/fvUMgXjaLve/5usGGHMu0M/0JJQUXIlIWqCl9+PGnHqKza9Lg9O/ca64r1h286D1Ivj68CifWTmWHZGwlcELj8CgS+pyYLsKS5nUTmmdlvCHm+YIFd0oqxfmQo0fL0ESZ/Lc8BrVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110076; c=relaxed/simple; bh=EPK3tsDP7MJ85z55tYMLTgK/U07/7rpBkB7b1Uy60oI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bfaUvIvWP+P0Chu0fLClYWrRsvMQ4XZCFVSO+BJ/rbF8W837O9zJTpkq//z4mJ519TP5ymvxyvAGwpF18Ync279MDZXeQKc+O45006vLIR52CIYAl8JfGIoS9LKOpidXVraS/QV3P8Ont8SEDPaRySOx42NDwy1vu+kbLZNarjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=bQRz6czt; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bQRz6czt" Received: from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FCDF517; Wed, 10 Jun 2026 18:47:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781110043; bh=EPK3tsDP7MJ85z55tYMLTgK/U07/7rpBkB7b1Uy60oI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bQRz6czt7COtbmKpgmfTE9daRxZwo1O3MtqNw5rc8cfNDcok/0yKa6dnYieTZgS1c p7X7kp9J2+LDNIB21IK913LRvgVtrS+qbrAHSbmOG6q29LItA8K2OyytjJa302ErQc 88/Nz4AgyUcu5GF4AwwT+1RasYC7M3pOC4JB/dBo= Date: Wed, 10 Jun 2026 18:47:49 +0200 From: Jacopo Mondi To: Ricardo Ribalda Cc: Jacopo Mondi , Dave Stevenson , Sakari Ailus , Mauro Carvalho Chehab , Xiaolei Wang , Tarang Raval , Lad Prabhakar , Daniel Scally , Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description Message-ID: References: <20260610-media-ci-7-2-v1-0-3c61a482a44e@chromium.org> <20260610-media-ci-7-2-v1-2-3c61a482a44e@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Jun 10, 2026 at 06:35:36PM +0200, Ricardo Ribalda wrote: > Hi Jacopo > > On Wed, 10 Jun 2026 at 18:30, Jacopo Mondi > wrote: > > > > Hi Ricardo > > > > On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote: > > > The variable has been previously removed but not its kerneldoc. > > > > > > Also remove the leftover reference to state in the description of qlock. > > > > > > This patch fixes the following warning: > > > > > > Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164 > > > Excess struct member 'state' description in 'rzg2l_cru_dev' > > > > upsie > > > > indeed! > > > > > > > > Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable") > > > > My only question is if this qualifies for stable or not... > > Honestly, I would drop the Fixes tag here > > Yeah, I am not even sure myself > > On one hand, it might help other CIs down there have cleaner logs, it > is very low risk, and I doubt that it will have any conflicts. > On the other, what real user will benefit from this backport? > > I wrote in the cover that this can be dropped. I'd let more clever > people decide :P > >From Documentation/process/stable-kernel-rules.rst: - It must either fix a real bug that bothers people or just add a device ID. To elaborate on the former: - It fixes a problem like an oops, a hang, data corruption, a real security issue, a hardware quirk, a build error (but not for things marked CONFIG_BROKEN), or some "oh, that's not good" issue. - Serious issues as reported by a user of a distribution kernel may also be considered if they fix a notable performance or interactivity issue. As these fixes are not as obvious and have a higher risk of a subtle regression they should only be submitted by a distribution kernel maintainer and include an addendum linking to a bugzilla entry if it exists and additional information on the user-visible impact. - No "This could be a problem..." type of things like a "theoretical race condition", unless an explanation of how the bug can be exploited is also provided. - No "trivial" fixes without benefit for users (spelling changes, whitespace cleanups, etc). Are Documentation warnings considered "build errors" ? > > > > > Signed-off-by: Ricardo Ribalda > > > > Reviewed-by: Jacopo Mondi > > > > > --- > > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > > > index 5bf334e173d2..b426bc7898bf 100644 > > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > > > @@ -116,11 +116,9 @@ struct rzg2l_cru_info { > > > * @scratch_phys: physical address of the scratch buffer > > > * > > > * @qlock: protects @queue_buf, @buf_list, @sequence > > > - * @state > > > * @queue_buf: Keeps track of buffers given to HW slot > > > * @buf_list: list of queued buffers > > > * @sequence: V4L2 buffers sequence number > > > - * @state: keeps track of operation state > > > * > > > * @format: active V4L2 pixel format > > > */ > > > > > > -- > > > 2.54.0.1099.g489fc7bff1-goog > > > > > > > -- > Ricardo Ribalda