From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7567A22A80D; Thu, 11 Jun 2026 06:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159896; cv=none; b=LtmGLGeC0xqUOzWowvrog0Xgroh5pS8JsaCBAx69s5kxv3KNa67BUxyrSf6gtq2P1t5yQ07wx+sI+bL3Pn33RJ4BxhObfVjxyd+C1F/UgJUPbHOlLFMtKFuXPGHyfMrZ4iniXr4lf5LjOjEtYwQLRMltlj4M16UGL5dbrKE9xRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159896; c=relaxed/simple; bh=k3XAFz/IStTJ0DH75E9TAovbheQQiYU+2mKiR3TafN0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IK9ID2y7GTnOsdxQsm20hw6Icx86ibzHOSOKtT0Q/E8hALqbGWa7/vMsKuqzLpouirhlG0YfmXTKEr7bHMC7+JI9VW8n8u9UckCnjGnF1IoGMIJ/SK1YQzfcuTZI4v0hrb/maMVfGHVrbNzqm6eH3wasgQUt8rjm/UMi5LXLYdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IOP1Efo1; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IOP1Efo1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781159894; x=1812695894; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=k3XAFz/IStTJ0DH75E9TAovbheQQiYU+2mKiR3TafN0=; b=IOP1Efo1Dk8crWjiYPHCTW5e6OF+gWlfmVP7Vvg+4efIH6gzB/k0X06W 9NPGHDlL5/4GXS/oqMlmAd3AL9VUHUxPcUyeVJvlml79MyPQZ3d7XqEHF i1fta08pzp09tqkxTrZpDO/TDhCnEaXsWiN1mEb+QatOsZ+KBkr2T8CG6 r6kDEIQaDPpoIMBK92clbpNamEf+P4MimyC10kBSTKgeqv/V6rYbHmkWn 9doDi3gurw9F7Le639HZJomeYiq0Y1qWHxYJYhv5xAUpYOtItzfKcqpTg QGOf/V+U8syMv8jPhy7pOI/vzfgGZXyI0U8stBQcxacdh0+fKMUsO5KNt g==; X-CSE-ConnectionGUID: bB4wkTMNT8+A3Ci0PJVjdQ== X-CSE-MsgGUID: Ry34irdtSj6Zr+5FA+WnUQ== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="85807176" X-IronPort-AV: E=Sophos;i="6.24,198,1774335600"; d="scan'208";a="85807176" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2026 23:38:13 -0700 X-CSE-ConnectionGUID: gwE1DvyaR8eEoLZ/6A83OA== X-CSE-MsgGUID: pzavm+jjQGui+db0dFXO1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,198,1774335600"; d="scan'208";a="284478092" Received: from abityuts-desk.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.136]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2026 23:38:12 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id D759811FC8C; Thu, 11 Jun 2026 09:38:07 +0300 (EEST) Date: Thu, 11 Jun 2026 09:38:07 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Tarang Raval Cc: Kate Hsuan , Mauro Carvalho Chehab , Hans de Goede , Hans Verkuil , Serin Yeh , Damjan Georgievski , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 3/3] media: i2c: imx471: Add Sony IMX471 image sensor driver Message-ID: References: <20260609124926.1038981-1-hpa@redhat.com> <20260609124926.1038981-4-hpa@redhat.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Tarang, On Thu, Jun 11, 2026 at 05:35:29AM +0000, Tarang Raval wrote: > Hi Sakari, > > > On Wed, Jun 10, 2026 at 07:11:39AM +0000, Tarang Raval wrote: > > > > + /* V4L2 controls values will be applied only when power is already up */ > > > > + if (!pm_runtime_get_if_in_use(sensor->dev)) > > > > > > Use pm_runtime_get_if_active() or update the comment. With pm_runtime_get_if_in_use(), > > > the comment should say "applied only when the device is in use". > > > > Using pm_runtime_get_if_active() would allow more sparing I²C writes, which > > I understand the driver always does in enable_streams(). It's not a bug > > though. > > Yes, you are right. My concern is only about the comment, as it does not accurately > describe the behavior when using pm_runtime_get_if_in_use(). That's why I said either > approach is fine, but if pm_runtime_get_if_in_use() is used, the comment should be > updated accordingly. I'd just drop the comment. Please also don't use more than ~ 75 characters per line in e-mails. -- Regards, Sakari Ailus