From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Elgin Perumbilly <elgin.perumbilly@siliconsignals.io>
Cc: laurent.pinchart@ideasonboard.com,
Tarang Raval <tarang.raval@siliconsignals.io>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Hans de Goede <johannes.goede@oss.qualcomm.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mehdi Djait <mehdi.djait@linux.intel.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Heimir Thor Sverrisson <heimir.sverrisson@gmail.com>,
Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] media: i2c: os02g10: implement crop handling with set_selection
Date: Thu, 18 Jun 2026 14:47:23 +0300 [thread overview]
Message-ID: <ajPay8NJ233yuCLJ@kekkonen.localdomain> (raw)
In-Reply-To: <20260424092554.26130-4-elgin.perumbilly@siliconsignals.io>
Hi Elgin,
On Fri, Apr 24, 2026 at 02:55:47PM +0530, Elgin Perumbilly wrote:
> From: Tarang Raval <tarang.raval@siliconsignals.io>
>
> Add crop support to os02g10 by implementing .set_selection() and
> storing the crop rectangle in subdev state.
>
> Initialize the default crop to the active area, make set_fmt() use the
> current crop, and update the output format when the crop size changes.
> Also program the sensor window from the active crop/format state instead
> of using the fixed supported_modes entry.
>
> This allows userspace to configure the sensor crop window explicitly.
Please wait for the Common Raw Sensor Model patches to be merged before
adding this -- we don't have an established way to configure cropping
before that. Some drivers might do something but it's all a bit haphazard.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2026-06-18 11:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:25 [PATCH v3 0/3] media: i2c: Add os02g10 camera sensor driver Elgin Perumbilly
2026-04-24 9:25 ` [PATCH v3 1/3] dt-bindings: media: i2c: Add os02g10 sensor Elgin Perumbilly
2026-04-25 9:43 ` Krzysztof Kozlowski
2026-06-12 9:35 ` Vladimir Zapolskiy
2026-04-24 9:25 ` [PATCH v3 2/3] media: i2c: add os02g10 image sensor driver Elgin Perumbilly
2026-06-12 10:12 ` Vladimir Zapolskiy
2026-06-18 6:22 ` Elgin Perumbilly
2026-06-18 10:56 ` sakari.ailus
2026-06-18 11:06 ` Vladimir Zapolskiy
2026-06-18 11:46 ` Laurent Pinchart
2026-06-18 11:43 ` Sakari Ailus
2026-06-18 12:27 ` Tarang Raval
2026-06-18 12:58 ` Laurent Pinchart
2026-06-18 13:01 ` Laurent Pinchart
2026-04-24 9:25 ` [PATCH v3 3/3] media: i2c: os02g10: implement crop handling with set_selection Elgin Perumbilly
2026-06-12 10:34 ` Vladimir Zapolskiy
2026-06-12 11:41 ` Tarang Raval
2026-06-12 13:16 ` Vladimir Zapolskiy
2026-06-12 14:20 ` Tarang Raval
2026-06-18 11:47 ` Sakari Ailus [this message]
2026-06-18 13:02 ` Laurent Pinchart
2026-06-18 13:36 ` Sakari Ailus
2026-04-24 12:14 ` [PATCH v3 0/3] media: i2c: Add os02g10 camera sensor driver Sakari Ailus
2026-04-24 13:28 ` Elgin Perumbilly
2026-04-25 9:42 ` Krzysztof Kozlowski
2026-05-21 5:15 ` Elgin Perumbilly
2026-06-11 7:39 ` Elgin Perumbilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajPay8NJ233yuCLJ@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elgin.perumbilly@siliconsignals.io \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=heimir.sverrisson@gmail.com \
--cc=hverkuil+cisco@kernel.org \
--cc=johannes.goede@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=robh@kernel.org \
--cc=sylvain.petinot@foss.st.com \
--cc=tarang.raval@siliconsignals.io \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox