Re: [PATCH 3/5] media: i2c: msp3400-driver: Add missing media_entity_cleanup()

[Jacopo Mondi <jacopo.mondi@ideasonboard.com>]

Hi Biren

On Fri, Jun 19, 2026 at 03:31:30PM +0530, Biren Pandya wrote:
> The probe error paths and remove function are missing calls to
> media_entity_cleanup(). Add them to prevent memory leaks if pads
> are dynamically allocated.
>
> Signed-off-by: Biren Pandya <birenpandya@gmail.com>
> ---
>  drivers/media/i2c/msp3400-driver.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/i2c/msp3400-driver.c b/drivers/media/i2c/msp3400-driver.c
> index 4c0b0ad68c08..d977a6039e6c 100644
> --- a/drivers/media/i2c/msp3400-driver.c
> +++ b/drivers/media/i2c/msp3400-driver.c
> @@ -812,6 +812,7 @@ static int msp_probe(struct i2c_client *client)
>  		int err = hdl->error;
>
>  		v4l2_ctrl_handler_free(hdl);
> +		media_entity_cleanup(&sd->entity);

This driver really seems a relic from the past, but if you want to add
media_entity_cleanup() to it, there is one previous error path after
media_entity_pads_init() where you might want to do that.


>  		return err;
>  	}
>
> @@ -865,6 +866,7 @@ static void msp_remove(struct i2c_client *client)
>  	msp_reset(client);
>
>  	v4l2_ctrl_handler_free(&state->hdl);
> +	media_entity_cleanup(&state->sd.entity);
>  }
>
>  /* ----------------------------------------------------------------------- */
> --
> 2.50.1 (Apple Git-155)
>
>