From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from extorris.mess.org (extorris.mess.org [92.243.27.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76F6E34B68F for ; Mon, 29 Jun 2026 14:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=92.243.27.206 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782742020; cv=none; b=HjKTUvlkg2ldUdvVROkHw16ZCUSwMJayY047j0k7FAZuaZr60at58SQfI4EKEUV/kL98n6OzbwwXXg+C7/xac80Rqmk9DZELkLUvjuXb8sqAFfRdlrbLg/VjisvWC/JkPxotyvqPLu+1qIHX4g95tioInwr4hbWRDauBrE5CU84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782742020; c=relaxed/simple; bh=GDsVR/UNKXv/636mkuVFOiM8B+XsgvIdghmpokwZ2RQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P/CH5z1O7YBXyGHnNg7Yr7oDf5P5mARbDVSQsppC2j3JHhwocj5HTvQvYK5QMPnIPGSwaIKA6J+7SyMiNUFUjb0WloIL/RHbawRFtX2KUzMHsMtWGPlTvLPVOEH2xFJa66ptJpLCDRdn14mlxrpVTOCqRtQpoj980adZ84mVtd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mess.org; spf=pass smtp.mailfrom=mess.org; dkim=pass (2048-bit key) header.d=mess.org header.i=@mess.org header.b=gHgQLEEv; arc=none smtp.client-ip=92.243.27.206 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mess.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mess.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mess.org header.i=@mess.org header.b="gHgQLEEv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1782741459; bh=GDsVR/UNKXv/636mkuVFOiM8B+XsgvIdghmpokwZ2RQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gHgQLEEvO3HCpPPeo9xZsJFU3Hi4wtqSo3RHlq/HCMLLCTVb14lJF4RctCCB9NiqA XXILBtdlXDhrql7OuPwH8mrj2rDO8zU6bmlAaC9YW0qBuM0eYZKn0VvB1826/68nIM QuJlwUFrbU1esA2DzaQjR9EP70EgHzI40tcjqb1a/izKDQxbWvN5aKjrGVGn4sQMID nqFvflH7tv8PfnWz6SGVZfvQxLTtp5Rzx8jLfpC15uqkOkF0pn+yz9J8nc5mh6y//S 32QyM/iJXP1Gv13bkkVaZpbJpqv/k+1wq0EnM8obgdX2NScwDc93r4wQd9svk8Kz+H PYa9tLxT8Kf8A== Received: by extorris.mess.org (Postfix, from userid 1001) id D041141CD1; Mon, 29 Jun 2026 14:57:39 +0100 (BST) Date: Mon, 29 Jun 2026 14:57:39 +0100 From: Sean Young To: Hans Verkuil Cc: Linux Media Mailing List Subject: Re: [PATCH] media: cec: extron-da-hd-4k-plus: add sanity check Message-ID: References: <362ab4a1-6591-4715-ad1e-956a65ec322c@kernel.org> <186b19c9-e9f0-42e1-8c40-c594022acd5a@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <186b19c9-e9f0-42e1-8c40-c594022acd5a@kernel.org> On Thu, Jun 18, 2026 at 01:16:22PM +0200, Hans Verkuil wrote: > On 18/06/2026 13:03, Hans Verkuil wrote: > > Add check to prevent overflowing msg.msg[] in case the incoming data > > is malformed. > > > > Signed-off-by: Hans Verkuil > > Fixes: 056f2821b631 ("media: cec: extron-da-hd-4k-plus: add the Extron DA HD 4K Plus CEC driver") > Cc: stable@vger.kernel.org Looks good. Reviewed-by: Sean Young > > Regards, > > Hans > > > --- > > diff --git a/drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c b/drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c > > index 3381d86096a1..3c6ce6f3d93e 100644 > > --- a/drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c > > +++ b/drivers/media/cec/usb/extron-da-hd-4k-plus/extron-da-hd-4k-plus.c > > @@ -657,7 +657,8 @@ static void extron_process_received(struct extron_port *port, const char *data) > > if (!port || port->disconnected) > > return; > > > > - if (len < 5 || (len - 2) % 3 || data[len - 2] != '*') > > + if (len < 5 || ((len - 2) / 3 > sizeof(msg.msg)) || > > + (len - 2) % 3 || data[len - 2] != '*') > > goto malformed; > > > > while (*data != '*') { > > >