From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 755843EBF0C for ; Tue, 30 Jun 2026 10:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814420; cv=none; b=c21SllxGlmORNZRnJlPc3Pu55DSpIHDC+QlQ0ApRFTCoacqr81uZjM4R9mp4S1VXnf9XJcYQzbKm/R73M76tCuMCH0YKNwDJ7YVJ2VhOTcyUukPXyeS7RzumxdO2sOuRVx+NnIbDH3m0K2YnBcWEHDq4Z+Qv2gSiNnFgi6CSXAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814420; c=relaxed/simple; bh=4s7TXf5Iw/XAphju1TikY5bLJx9/ScKVxN/mvYdVLBs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EYI9cv1NvbHK9MfuSBxJlYet+JdHFqCMUevh21qG5H5F/ZH7uy+YDNSRynXsZqmQMMaR0kGdJ6CjllIP59DXm2g7+Up3UBOoYUX4hWVZle/iDmxCRKNNOnVE2a4NVmnVDESw2Ff+4ghd0APcjCf/NNs6Ml4ZDeHxa5UxRMMXdZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gGY9bJTQ; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gGY9bJTQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782814419; x=1814350419; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4s7TXf5Iw/XAphju1TikY5bLJx9/ScKVxN/mvYdVLBs=; b=gGY9bJTQJTqVgf9KcVB24iet7Tvpr17vRO7iDeTV0vfzmQN6ysli3xmZ rrTJgp9Tb6GCYv1+f33pE0S5wxaCepcrO2oiMjxKB7+Ioa+h7LXqKXuvn N2gpe+ytYeOUNijws742TnwMMVEx+ADL3ZbJ37nqtjzo4NviNsUeW8X9x JJ7UfcpRy+anmXICQt/dburU7VZMXvXTD4/xJl+C75JlAVQYCuyt1/oQE TTHzDO9u1hfMDwetuGzdjVFczF0kpbtfRn8BE/gtn2IQ4XbzZvC2Rz8lx strH+K9qDTeNY+HERO6Oz5AK3EMYIypbMOWtlMtaQJoie8TxuZeW5FcW3 A==; X-CSE-ConnectionGUID: BZ9139FcSYutlX8zTh88MA== X-CSE-MsgGUID: kP/SAuU9TZO5U+9fnrKpGA== X-IronPort-AV: E=McAfee;i="6800,10657,11832"; a="83580613" X-IronPort-AV: E=Sophos;i="6.24,233,1774335600"; d="scan'208";a="83580613" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2026 03:13:38 -0700 X-CSE-ConnectionGUID: f/ixbV5JSWSOR7EfGCAb8g== X-CSE-MsgGUID: 5CCVw+KoQUukkidj5Es4QQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,233,1774335600"; d="scan'208";a="245876159" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.116]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2026 03:13:38 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 7EE29121C13; Tue, 30 Jun 2026 13:13:38 +0300 (EEST) Date: Tue, 30 Jun 2026 13:13:38 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Hans Verkuil Cc: linux-media@vger.kernel.org, Mauricio Faria de Oliveira Subject: Re: [PATCHv4 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is, empty Message-ID: References: <2cf4473a9c16d0715aa081e234bb36c70fefce3c.1782716154.git.hverkuil+cisco@kernel.org> <05d38e6d-5f18-4d70-983b-1a28ddd22535@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05d38e6d-5f18-4d70-983b-1a28ddd22535@kernel.org> Hi Hans, Thanks for the update. Did you notice my comment on the subject? On Tue, Jun 30, 2026 at 12:02:53PM +0200, Hans Verkuil wrote: > When my em28xx USB device that uses the i2c tvp5150 driver is > disconnected, it crashes. > > The cause is that the tvp5150 i2c module uses v4l2_async, but > the em28xx driver does not since it predates v4l2_async. > > In that corner case sd->asc_list is empty, so > v4l2_async_unregister_subdev() never calls v4l2_device_unregister_subdev(). > > Modify the code so that, if sd->asc_list is empty, > v4l2_device_unregister_subdev() is still called. > > Fixes: 28a1295795d8 ("media: v4l: async: Allow multiple connections between entities") > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus -- Kind regards, Sakari Ailus