From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE952750E6; Sat, 4 Jul 2026 19:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783192599; cv=none; b=UH9zzQQagnvNhmoXR0wKxV4lW0rdk50SXNeZ3PgMWcO+KWw3Ka6hy7IZB1uX4aGDi5Tn72V78XLTeWJzONdkjnsIFDsyqi8VMFyNo5OOaD6rueaFOTOmpuePza9sJTB214zoz1xEwmxxf+ThocIt8DrDFn0IgvnsyElZcVDF15w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783192599; c=relaxed/simple; bh=q8I1b/ESMjjJgXoEisyy//ZVVILPMKwxuT6+E+794WU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pIqo9Szfpy5FcDzDLoHA/lFJ9KHpPclHsnmrHXlfWlNx4dAAm8d7zAAd+vWQc30wkmz6T/5FSHn1ZVCe4SjXu3//WLXytBTNCFbUWjUopDLVug5d6Ur2zjCfMLSuZf/PE7ot4DBtCBpIfU2dXMhivsiluFDRouwBGUSuJwzPdGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cz2a7ig3; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cz2a7ig3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783192597; x=1814728597; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=q8I1b/ESMjjJgXoEisyy//ZVVILPMKwxuT6+E+794WU=; b=cz2a7ig3ZjnJUwIsRZaKGHOvQxTkshayZMYo4870wppunfT/Y7T86Y/j 2wKBjPDD9x5VaZycqDtQIFoBrMGnbntkym36ZgMylaNbB+gr2/kTTWfT+ XA/PsO9PoY8h3bmhBMXh6eHadANIEfjfb2mi8kt6NBuJPSEWnV/wWEXW9 BaoMOLrD0yZDCy1UFO/V8z/T66alE1xPPMbrBcmVjk7zkem/8IQw7/sjK fa8E3Ri5RaKWL9oU63D3akeUUh4TVvj8OilkU4UsSOIQNnvCoxjBGWNim 4SESK1JLDPAiNWP2VWBzKQzqm6aZs2ccdjqdzxj0HWDh48GJIE0igH0un g==; X-CSE-ConnectionGUID: sBCkZbzhRNe2eDCAWoTY2w== X-CSE-MsgGUID: tHtakjJHSPq5co9PqmSv6A== X-IronPort-AV: E=McAfee;i="6800,10657,11837"; a="87570897" X-IronPort-AV: E=Sophos;i="6.25,148,1779174000"; d="scan'208";a="87570897" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2026 12:16:37 -0700 X-CSE-ConnectionGUID: YVfTG/+gQfiUa3s88E1N1w== X-CSE-MsgGUID: E1u3m22ZQj6b/WqoB9xXJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,148,1779174000"; d="scan'208";a="277681934" Received: from slindbla-desk.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.246]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2026 12:16:34 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 91A69120DF0; Sat, 04 Jul 2026 22:16:32 +0300 (EEST) Date: Sat, 4 Jul 2026 22:16:32 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Hans de Goede Cc: Tarang Raval , Kate Hsuan , Mauro Carvalho Chehab , Hans Verkuil , Serin Yeh , Damjan Georgievski , Kieran Bingham , computman , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Scally , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , "platform-driver-x86@vger.kernel.org" Subject: Re: [PATCH v6 3/4] platform: int3472: discrete: con_id vana for Sony IMX471 as power enable Message-ID: References: <20260629074026.35490-1-hpa@redhat.com> <20260629074026.35490-4-hpa@redhat.com> <49257d09-a2fd-4a9d-9479-4d2b5e0fb8a6@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Hans, Tarang, On Thu, Jul 02, 2026 at 08:05:25PM +0200, Hans de Goede wrote: > > I went through the INT3472 driver and would like to propose a generic > > approach that satisfies both sides without per-HID quirks or sensor driver > > changes. > > > > The problem is: > > - INT3472 standardizes on "avdd" internally > > - Sony IMX sensor drivers use "vana" per datasheet, and all existing > > Sony DT bindings (imx219, imx290, imx415) already use vana-supply > > - Changing imx471 to "avdd" now will create inconsistency with those > > bindings, or require a rename later > > Ack, as mentioned in my reply to Sakari from 1 minute ago I'm ok > with sticking with vana for the imx* case, At least some Sony sensors use "INT" PnP vendor prefix and so telling them apart from the rest doesn't work at least this way. There could also be other prefixes as well, they're not all "SONY". Right now there is one with INT prefix and three with SONY prefix. If we start having lots of devices with the same quirk, we could also introduce a pointer to an array of IDs to avoid repeating the same quirk over and over. Kate's patch adds two quirks so this could be already considered (and only one of these IDs is using SONY prefix). -- Regards, Sakari Ailus