From: Dan Carpenter <error27@gmail.com>
To: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3] staging: media: atomisp: Remove pad_w and pad_h module parameters
Date: Mon, 20 Jul 2026 14:49:19 +0300 [thread overview]
Message-ID: <al4LPyMIZ2F5EElx@stanley.mountain> (raw)
In-Reply-To: <20260720112807.6348-1-prajvalchaudhari733@gmail.com>
On Mon, Jul 20, 2026 at 04:58:07PM +0530, Prajval Chaudhary wrote:
> Hi Andy, Dan, Hans,
>
> Thank you for the review and catching this.
>
> In this v3, I have completely dropped the changes to the debug
> parameters to keep the staging debug facilities fully intact as requested.
>
> This patch now strictly focuses on removing the 'pad_w' and 'pad_h'
> module parameters and converting them into internal driver constants.
>
> Remove the 'pad_w' and 'pad_h' module parameters to prevent userspace
> from overriding internal ISP hardware padding boundaries. Convert them
> into internal driver constants instead.
>
> This partially addresses the 'Remove unnecessary/unwanted module
> parameters' task in the driver's TODO file, while keeping the debug
> facilities intact as requested by maintainers.
>
> Signed-off-by: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
> ---
No. The real answer requires is a bit complicated and requires
some thought.
regards,
dan carpenter
prev parent reply other threads:[~2026-07-20 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 11:28 [PATCH v3] staging: media: atomisp: Remove pad_w and pad_h module parameters Prajval Chaudhary
2026-07-20 11:37 ` Andy Shevchenko
2026-07-20 11:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4LPyMIZ2F5EElx@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=prajvalchaudhari733@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox