From: Dan Carpenter <error27@gmail.com>
To: erqeons <erqeon@gmail.com>
Cc: gregkh@linuxfoundation.org, hansg@kernel.org, andy@kernel.org,
mchehab@kernel.org, sakari.ailus@intel.com,
linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: fix indentation and remove dead return
Date: Sat, 11 Jul 2026 12:16:35 +0300 [thread overview]
Message-ID: <alIJ83ctZ7NDzBhF@stanley.mountain> (raw)
In-Reply-To: <20260711081657.37117-1-erqeon@gmail.com>
On Sat, Jul 11, 2026 at 12:16:57PM +0400, erqeons wrote:
> Fix style issues reported by checkpatch.pl:
> - Remove unnecessary return statement in void function.
> - Convert spaces to tabs for function arguments indentation.
Split this into two patches.
>
> Signed-off-by: erqeons <erqeon@gmail.com>
Real name, please.
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 6cd500d9f..fb1ae146b 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
>
> err:
> atomisp_css_free_stat_buffers(asd);
> - return;
> }
>
> static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,
> @@ -1885,8 +1884,8 @@ int atomisp_calculate_real_zoom_region(struct atomisp_sub_device *asd,
> * Function to check the zoom region whether is effective
> */
> static bool atomisp_check_zoom_region(
> - struct atomisp_sub_device *asd,
> - struct ia_css_dz_config *dz_config)
> + struct atomisp_sub_device *asd,
> + struct ia_css_dz_config *dz_config)
Normally we would align it like this:
static bool atomisp_check_zoom_region(struct atomisp_sub_device *asd,
struct ia_css_dz_config *dz_config)
{
regards,
dan carpenter
prev parent reply other threads:[~2026-07-11 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 8:16 [PATCH] staging: media: atomisp: fix indentation and remove dead return erqeons
2026-07-11 9:16 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alIJ83ctZ7NDzBhF@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=erqeon@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox