From: Johan Hovold <johan@kernel.org>
To: Lei Huang <huanglei814@163.com>
Cc: mchehab@kernel.org, hverkuil+cisco@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Lei Huang <huanglei@kylinos.cn>
Subject: Re: [PATCH v2 1/2] media: s2255: Rename CamelCase goto labels to snake_case
Date: Wed, 15 Jul 2026 12:00:50 +0200 [thread overview]
Message-ID: <aldaUlUq8bGDsJgT@hovoldconsulting.com> (raw)
In-Reply-To: <20260715092947.772768-1-huanglei814@163.com>
On Wed, Jul 15, 2026 at 05:29:46PM +0800, Lei Huang wrote:
> From: Lei Huang <huanglei@kylinos.cn>
>
> Rename the error-path goto labels in s2255_probe() from CamelCase to
> snake_case to comply with the Linux kernel coding style:
>
> errorBOARDINIT -> err_boardinit
> errorFWMARKER -> err_fwmarker
> errorREQFW -> err_reqfw
> errorFWDATA2 -> err_fwdata2
> errorFWURB -> err_fwurb
> errorEP -> err_ep
> errorUDEV -> err_udev
> errorFWDATA1 -> err_fwdata1
>
> No functional changes; all label definitions and goto references are
> updated consistently.
>
> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
This looks ok, but the fix should go before the cleanup (e.g. to
facilitate backporting).
Also, always include a changelog (in a coverletter) when updating a
series.
Johan
next prev parent reply other threads:[~2026-07-15 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 9:29 [PATCH v2 1/2] media: s2255: Rename CamelCase goto labels to snake_case Lei Huang
2026-07-15 9:29 ` [PATCH v2 2/2] media: s2255: check firmware size before reading trailing marker Lei Huang
2026-07-15 10:00 ` Johan Hovold [this message]
2026-07-15 12:05 ` [PATCH v2 1/2] media: s2255: Rename CamelCase goto labels to snake_case hverkuil+cisco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aldaUlUq8bGDsJgT@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=huanglei814@163.com \
--cc=huanglei@kylinos.cn \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox