Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

Mauro Carvalho Chehab
2012-10-09T23:50:34Z

Hi Julia,

Em Mon, 8 Oct 2012 10:31:33 +0200 (CEST)
Julia Lawall <julia.lawall@lip6.fr> escreveu:

> I found only 15 uses of I2C_MSG_OP, out of 653 uses of one of the three
> macros. Since I2C_MSG_OP has the complete set of flags, I think it should
> be OK?
>
> One of the uses, in drivers/media/i2c/adv7604.c, is as follows:
>
> struct i2c_msg msg[2] = { { client->addr, 0, 1, msgbuf0 },
> { client->addr, 0 | I2C_M_RD, len, msgbuf1 }
>
> I'm not sure what was intended, but I guess the second structure is
> supposed to only do a read?

As we're discussing the macro names, etc, I'll just mark this patch series
as RFC, at patchwork, removing it from my pending queue. Feel free to
re-submit it later, after some agreement got reached.

Thanks,
Mauro