From: Julia Lawall <julia.lawall@inria.fr>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Malcolm Priestley" <tvboxspy@gmail.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Joe Perches" <joe@perches.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
kernel-janitors@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/20] media: lmedm04: use semicolons rather than commas to separate statements
Date: Tue, 29 Sep 2020 18:43:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2009291840470.2808@hadrien> (raw)
In-Reply-To: <8d73748e-be82-4c30-4550-b5f4eecb3055@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]
On Tue, 29 Sep 2020, Christophe JAILLET wrote:
> Le 29/09/2020 à 15:14, Julia Lawall a écrit :
> > Replace commas with semicolons. Commas introduce unnecessary
> > variability in the code structure and are hard to see. What is done
> > is essentially described by the following Coccinelle semantic patch
> > (http://coccinelle.lip6.fr/):
> >
> > // <smpl>
> > @@ expression e1,e2; @@
> > e1
> > -,
> > +;
> > e2
> > ... when any
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> >
> > ---
> > drivers/media/usb/dvb-usb-v2/lmedm04.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c
> > b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> > index 5a7a9522d46d..9ddda8d68ee0 100644
> > --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
> > +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> > @@ -391,7 +391,7 @@ static int lme2510_int_read(struct dvb_usb_adapter
> > *adap)
> > ep = usb_pipe_endpoint(d->udev, lme_int->lme_urb->pipe);
> > if (usb_endpoint_type(&ep->desc) == USB_ENDPOINT_XFER_BULK)
> > - lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa),
> > + lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa);
> > usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC);
> > info("INT Interrupt Service Started");
> >
> >
> Ouch!
>
> This one looks like a real issue!
Oops, yes, I meant to make a comment about it.
Joe may have sent this patch already. At least he has sent a patch on an
issue like this.
julia
next prev parent reply other threads:[~2020-09-29 16:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 13:14 [PATCH 00/20] media: use semicolons rather than commas to separate statements Julia Lawall
2020-09-29 13:14 ` [PATCH 01/20] media: coda: " Julia Lawall
2020-09-29 14:06 ` Philipp Zabel
2020-09-29 13:14 ` [PATCH 02/20] media: em28xx-audio: " Julia Lawall
2020-09-29 13:14 ` [PATCH 03/20] media: rtl28xxu: " Julia Lawall
2020-09-29 13:14 ` [PATCH 04/20] media: saa7134: " Julia Lawall
2020-09-29 15:57 ` Christophe JAILLET
2020-09-29 16:46 ` Julia Lawall
2020-09-29 13:14 ` [PATCH 05/20] media: m88ds3103: " Julia Lawall
2020-09-29 13:14 ` [PATCH 06/20] media: gspca: ov534-ov772x: " Julia Lawall
2020-09-29 13:14 ` [PATCH 07/20] media: s3c-camif: " Julia Lawall
2020-09-29 13:14 ` [PATCH 08/20] media: sun4i-csi: " Julia Lawall
2020-09-29 13:14 ` [PATCH 09/20] media: pvrusb2: " Julia Lawall
2020-09-29 13:14 ` [PATCH 10/20] media: lmedm04: " Julia Lawall
2020-09-29 16:00 ` Christophe JAILLET
2020-09-29 16:42 ` Joe Perches
2020-09-29 16:44 ` Julia Lawall
2020-09-29 22:21 ` Joe Perches
2020-09-30 1:27 ` Joe Perches
2020-09-29 16:56 ` Julia Lawall
2020-09-29 18:43 ` Julia Lawall
2020-09-29 16:43 ` Julia Lawall [this message]
2020-09-29 13:14 ` [PATCH 11/20] media: ts2020: " Julia Lawall
2020-09-29 13:14 ` [PATCH 12/20] media: msp3400: " Julia Lawall
2020-09-29 13:14 ` [PATCH 13/20] media: radio-sf16fmr2: " Julia Lawall
2020-09-29 13:14 ` [PATCH 14/20] media: mt2060: " Julia Lawall
2020-09-29 13:14 ` [PATCH 15/20] media: au0828: " Julia Lawall
2020-09-29 13:14 ` [PATCH 16/20] media: dvbsky: " Julia Lawall
2020-09-29 13:14 ` [PATCH 17/20] media: dib0700: " Julia Lawall
2020-09-29 13:14 ` [PATCH 18/20] media: rtl2832: " Julia Lawall
2020-09-29 13:14 ` [PATCH 19/20] media: exynos4-is: " Julia Lawall
2020-09-29 13:14 ` [PATCH 20/20] media: bttv: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2009291840470.2808@hadrien \
--to=julia.lawall@inria.fr \
--cc=christophe.jaillet@wanadoo.fr \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tglx@linutronix.de \
--cc=tvboxspy@gmail.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox