From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C476C47423 for ; Tue, 29 Sep 2020 16:45:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 434D5208FE for ; Tue, 29 Sep 2020 16:45:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729519AbgI2Qo7 (ORCPT ); Tue, 29 Sep 2020 12:44:59 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:1717 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728531AbgI2Qo7 (ORCPT ); Tue, 29 Sep 2020 12:44:59 -0400 X-IronPort-AV: E=Sophos;i="5.77,319,1596492000"; d="scan'208";a="470117611" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 18:44:57 +0200 Date: Tue, 29 Sep 2020 18:44:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches cc: Christophe JAILLET , Malcolm Priestley , =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= , Thomas Gleixner , kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/20] media: lmedm04: use semicolons rather than commas to separate statements In-Reply-To: Message-ID: References: <1601385283-26144-1-git-send-email-Julia.Lawall@inria.fr> <1601385283-26144-11-git-send-email-Julia.Lawall@inria.fr> <8d73748e-be82-4c30-4550-b5f4eecb3055@wanadoo.fr> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-647752560-1601397897=:2808" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-647752560-1601397897=:2808 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 29 Sep 2020, Joe Perches wrote: > On 2020-09-29 09:00, Christophe JAILLET wrote: > > Le 29/09/2020 à 15:14, Julia Lawall a écrit : > > > Replace commas with semicolons. Commas introduce unnecessary > > > variability in the code structure and are hard to see. What is done > > > is essentially described by the following Coccinelle semantic patch > > > (http://coccinelle.lip6.fr/): > > > > > > // > > > @@ expression e1,e2; @@ > > > e1 > > > -, > > > +; > > > e2 > > > ... when any > > > // > > > > > > Signed-off-by: Julia Lawall > > > > > > --- > > > drivers/media/usb/dvb-usb-v2/lmedm04.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c > > > b/drivers/media/usb/dvb-usb-v2/lmedm04.c > > > index 5a7a9522d46d..9ddda8d68ee0 100644 > > > --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c > > > +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c > > > @@ -391,7 +391,7 @@ static int lme2510_int_read(struct dvb_usb_adapter > > > *adap) > > > ep = usb_pipe_endpoint(d->udev, lme_int->lme_urb->pipe); > > > if (usb_endpoint_type(&ep->desc) == USB_ENDPOINT_XFER_BULK) > > > - lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa), > > > + lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa); > > > usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC); > > > info("INT Interrupt Service Started"); > > > > > > > > Ouch! > > > > This one looks like a real issue! > > > Julia? Did you do this one by hand? This actually changes logic which I did > not expectthe cocci script to do. No, I didn't do it by hand. Did you already send this one? Maybe I should resend it with a more informative log message. julia > > CJ > --8323329-647752560-1601397897=:2808--