From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B1FC433B4 for ; Thu, 8 Apr 2021 21:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4653F610E6 for ; Thu, 8 Apr 2021 21:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbhDHVQy (ORCPT ); Thu, 8 Apr 2021 17:16:54 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:63589 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232397AbhDHVQy (ORCPT ); Thu, 8 Apr 2021 17:16:54 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ASlvcwKu6vrHd31bb0UzpIfrj7skCn4Aji2hD?= =?us-ascii?q?6mlwRA09T+WxjMqunOsW2FvdlV8qKTQdsPqHP7SNRm6Z0JZz75UYM7vKZniUhE?= =?us-ascii?q?KDKoZ+4Yz+hwDxAiGWzJ8s6Y5Me7VzYeeAcWRSoMr+4Ba1CNoshOSAmZrJuc7z?= =?us-ascii?q?1GxqVhsvVqcI1XYxNi+1CUtzLTM2fKYRNJ3Z3cZfoirlRHJ/VLXLOlAhX/Lf4/?= =?us-ascii?q?XRnpPnfhJuPW9k1CCqjSm0rJ/3FgHw5GZQbxprwa0+tUjJ+jaJqpmLlvGg11v7?= =?us-ascii?q?yWje9P1t6Zjc4/5CHtHJs84ON1zX+0aVTaFgQaDHhiw/uuu16F0n+eO87SsIGs?= =?us-ascii?q?Ro9jfseXuoqgHmwAnq3F8Vmj7f4Hu5pVemnsDjXjI9DKN69PxkWz/U8VApst05?= =?us-ascii?q?8I8j5RPli7NvFh/LkCnw4NLFPisa3jv+nVMYneQej2NSXOIlAdc7x+Fyky0lc+?= =?us-ascii?q?ZjbUaKj/FALMBUAM7R//pQe1+BBkqpxFVH+9C0W2R2IxHueDl7huWu3z9akGsR?= =?us-ascii?q?9TpT+OUkgnwC+JghIqM0k9jsD6IArsA0cuYrd65nQM8OTcyrY1a9Pi7kASa4IU?= =?us-ascii?q?fuE68OUki98KLf0fER4ueyEaZ4u6caqdDmS1NXtWk7fgbVD9GU1pEO0imlehT4?= =?us-ascii?q?YR3djudE55Z4vbX4AIfsWBfjdHke1+26o/seBcXHW/G8fLJuasWTX1fGKMJz0w?= =?us-ascii?q?r3RpVIbUMTS9IYofEyX17mmLOSFqTa8tfWd/7PKKGoKy8tXkn2HmEONQKDfflo?= =?us-ascii?q?3wSRVnjxnRTLH0n1ckjE95RqHMHhjq4u4blIDYFKuhUYkhCC/8mOEyBLr6BeRj?= =?us-ascii?q?o4HJrX1pm2vXW7+mzFhl8ZTCZ1PwJr6LDhXntWpQkMd0jlGIxzzum3SCRs3GCa?= =?us-ascii?q?PFtERcvQFwJTzm4HnJ6fHtiWw2QrENinMn2X5kFj6U63cw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.82,207,1613430000"; d="scan'208";a="502294565" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 23:16:41 +0200 Date: Thu, 8 Apr 2021 23:16:41 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mitali Borkar cc: clabbe@baylibre.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in Subject: Re: [Outreachy kernel] [PATCH 1/2] media: zoran: add spaces around '<<' In-Reply-To: <8e8ac690d97478f7cbb9b91d46ef7a95e4444e5f.1617912177.git.mitaliborkar810@gmail.com> Message-ID: References: <8e8ac690d97478f7cbb9b91d46ef7a95e4444e5f.1617912177.git.mitaliborkar810@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 9 Apr 2021, Mitali Borkar wrote: > Added spaces around '<<' operator to improve readability and meet linux > kernel coding style. > Reported by checkpatch > > Signed-off-by: Mitali Borkar > --- > drivers/staging/media/zoran/zr36057.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h > index 71b651add35a..a2a75fd9f535 100644 > --- a/drivers/staging/media/zoran/zr36057.h > +++ b/drivers/staging/media/zoran/zr36057.h > @@ -30,13 +30,13 @@ > #define ZR36057_VFESPFR_HOR_DCM 14 > #define ZR36057_VFESPFR_VER_DCM 8 > #define ZR36057_VFESPFR_DISP_MODE 6 > -#define ZR36057_VFESPFR_YUV422 (0<<3) > -#define ZR36057_VFESPFR_RGB888 (1<<3) > -#define ZR36057_VFESPFR_RGB565 (2<<3) > -#define ZR36057_VFESPFR_RGB555 (3<<3) > -#define ZR36057_VFESPFR_ERR_DIF (1<<2) > -#define ZR36057_VFESPFR_PACK24 (1<<1) > -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0) > +#define ZR36057_VFESPFR_YUV422 (0 << 3) > +#define ZR36057_VFESPFR_RGB888 (1 << 3) > +#define ZR36057_VFESPFR_RGB565 (2 << 3) > +#define ZR36057_VFESPFR_RGB555 (3 << 3) > +#define ZR36057_VFESPFR_ERR_DIF (1 << 2) > +#define ZR36057_VFESPFR_PACK24 (1 << 1) > +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0) Are these all aligned in the actual file? julia > #define ZR36057_VDTR 0x00c /* Video Display "Top" Register */ > > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/8e8ac690d97478f7cbb9b91d46ef7a95e4444e5f.1617912177.git.mitaliborkar810%40gmail.com. >