From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52720C04A95 for ; Tue, 25 Oct 2022 05:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbiJYFB7 (ORCPT ); Tue, 25 Oct 2022 01:01:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiJYFB5 (ORCPT ); Tue, 25 Oct 2022 01:01:57 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FFB77AB39; Mon, 24 Oct 2022 22:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=2RpF6v7jb3J8a21THqvWGqERHWXHNn7kIyc4VmrIpDk=; b=Y8f5U39imdcBre/bcuSCHN6VcfZ7BHURtK+YcMjJZJcWLqh+F9oJuZvz Jb+1Y/ON5am8w7SGHXfYjFMl7j2RoH3irDodGjf8UpQRgikKmfsChWMfu 4v+fzyTDGn+OhUsaPdLTUtMy0dwaXeGhcAQjK1U6CuGblFcGeIwCKunkc I=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.95,211,1661810400"; d="scan'208";a="33948386" Received: from 51.123.68.85.rev.sfr.net (HELO hadrien) ([85.68.123.51]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2022 07:01:48 +0200 Date: Tue, 25 Oct 2022 07:01:48 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Gabriel Lima Luz cc: Rui Miguel Silva , Laurent Pinchart , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment In-Reply-To: <20221025001239.16345-1-lima.gabriel.luz@gmail.com> Message-ID: References: <20221025001239.16345-1-lima.gabriel.luz@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, 24 Oct 2022, Gabriel Lima Luz wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > CHECK: Alignment should match open parenthesis Here you have made a decision that is quite reasonable, but that does not actually "Fix parenthesis alignment". This highlights an overall problem with your log message. You say what you are "fixing", but you don't give any explanation about why you have done what you have done. Actually the most helpful comment was below the ---, but that will disappear when the patch is applied. julia > > Signed-off-by: Gabriel Lima Luz > --- > Altered changes acording to feedback for a more readable code > > drivers/staging/media/imx/imx7-media-csi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c > index cbc66ef0eda8..b241b68f456c 100644 > --- a/drivers/staging/media/imx/imx7-media-csi.c > +++ b/drivers/staging/media/imx/imx7-media-csi.c > @@ -1704,7 +1704,8 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd, > mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace); > mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace); > mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv, > - mf->colorspace, mf->ycbcr_enc); > + mf->colorspace, > + mf->ycbcr_enc); > > csi->cc[i] = cc; > } > -- > 2.34.1 > > >