From: Weijie Yuan <wy@wyuan.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: 岳秉坤 <yuebingkun@kylinos.cn>,
mchehab@kernel.org, tony.luck@intel.com, corbet@lwn.net,
shiju.jose@huawei.com, jacopo.mondi@ideasonboard.com,
laurent.pinchart@ideasonboard.com, hverkuil+cisco@kernel.org,
sakari.ailus@linux.intel.com, linux-doc@vger.kernel.org,
linux-edac@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Documentation: fix "should be use" grammar in ABI README
Date: Tue, 28 Jul 2026 13:48:09 +0800 [thread overview]
Message-ID: <amhCmSxLtu4m6fXX@wyuan.org> (raw)
In-Reply-To: <f7a7b4d8-d044-491f-827c-ec929ee429ce@infradead.org>
On Mon, Jul 27, 2026 at 09:31:35PM -0700, Randy Dunlap wrote:
> >> Signed-off-by: 岳秉坤 <yuebingkun@kylinos.cn>
> >> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Usually, your "Signed-off-by" should be the last trailer.
>
> Hm, I disagree. The -by: lines are somewhat in chronological order, so this
> looks fine to me.
>
> Documentation/process/submitting-patches.rst says:
> """
> Standard sign-off
> procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
> chronological history of the patch insofar as possible, regardless of whether
> the author is attributed via From: or Co-developed-by:. Notably, the last
> Signed-off-by: must always be that of the developer submitting the patch.
> """
>
> Yes, this doesn't address Acked-by: or Reviewed-by: lines, but in my experience,
> chronological order applies to all of them.
Ah, I remember this part. But I tend to believe that this description is
only relevant to the issue of the order of Co-authored-by and
Signed-off-by, if I were the newcomer reading this for the first time.
(In fact, I actually am a newcomer compared with you ;-))
That is to say, when dealing with multiple authors, we suggest using
trailers to represent the sequence of authors in chronological order.
Then, this will facilitate subsequent readers to understand the
development history of the patch through the order of the trailers.(?)
And, aren't these subsequent examples merely confining the discussion to
these two trailers?
---
<changelog>
Co-developed-by: First Co-Author <first@coauthor.example.org>
Signed-off-by: First Co-Author <first@coauthor.example.org>
Co-developed-by: Second Co-Author <second@coauthor.example.org>
Signed-off-by: Second Co-Author <second@coauthor.example.org>
Signed-off-by: From Author <from@author.example.org>
---
Besides the submitting-patches file, It seems to me that the probability
of "Signed-off-by" appearing on the last line is much higher than in
other cases. Is this a usual practice? It seems that everyone tacitly
agreed to write "Acked-by" and "Reviewed-by" at the top, even though
they occurred after "Sob".
But of course, you have much more experience in this area, so my limited
observations may not be very representative.
Thanks!
ps. The Git project explicitly stipulates "Place this `Signed-off-by:`
trailer at the end". So at first, I wasn't quite sure about it.
next prev parent reply other threads:[~2026-07-28 5:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 4:12 [PATCH v2 0/3] Documentation: fix a few typo and wording issues 岳秉坤
2026-07-28 4:12 ` [PATCH v2 1/3] Documentation: fix "should be use" grammar in ABI README 岳秉坤
2026-07-28 4:24 ` Weijie Yuan
2026-07-28 4:31 ` Randy Dunlap
2026-07-28 5:48 ` Weijie Yuan [this message]
2026-07-28 16:55 ` Randy Dunlap
2026-07-28 17:15 ` Weijie Yuan
2026-07-28 17:25 ` Luck, Tony
2026-07-28 17:51 ` Weijie Yuan
2026-07-28 4:12 ` [PATCH v2 2/3] Documentation: fix "readng" typo in EDAC memory-repair ABI doc 岳秉坤
2026-07-28 4:12 ` [PATCH v2 3/3] Documentation: fix "thare are" typo in V4L subdev routing doc 岳秉坤
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amhCmSxLtu4m6fXX@wyuan.org \
--to=wy@wyuan.org \
--cc=corbet@lwn.net \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
--cc=yuebingkun@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox