From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Neal Patalay <nealpatalay0@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, andy@kernel.org,
gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
matt@mattwardle.net, mugrinphoto@gmail.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v5] staging: media: atomisp: refactor pipe graph dump stage formatting
Date: Tue, 11 Aug 2026 18:00:18 +0300 [thread overview]
Message-ID: <ans5AreArUHVP-MA@ashevche-desk.local> (raw)
In-Reply-To: <20260708042939.40420-1-nealpatalay0@gmail.com>
On Tue, Jul 07, 2026 at 09:29:39PM -0700, Neal Patalay wrote:
> The original implementation of ia_css_debug_pipe_graph_dump_stage()
> includes an off-by-one error where the original strscpy() size drops
> characters immediately before newlines. It also allocates over 600
> bytes across multiple buffers on the stack and truncates all output
> debug information after three lines. Fix the strscpy() bug, reduce
> stack usage with a single 256 byte buffer, and remove the three line
> limit via a new helper function, ia_css_debug_build_info().
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-11 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 4:29 [PATCH v5] staging: media: atomisp: refactor pipe graph dump stage formatting Neal Patalay
2026-08-11 15:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ans5AreArUHVP-MA@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matt@mattwardle.net \
--cc=mchehab@kernel.org \
--cc=mugrinphoto@gmail.com \
--cc=nealpatalay0@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox