From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
Cc: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailios@linux.intel.com, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver.
Date: Tue, 11 Aug 2026 17:02:46 +0300 [thread overview]
Message-ID: <ansrhooPovRKlz3v@ashevche-desk.local> (raw)
In-Reply-To: <20260722054615.21492-1-prajvalchaudhari733@gmail.com>
On Wed, Jul 22, 2026 at 11:16:13AM +0530, Prajval Chaudhary wrote:
> Patch 1 converts 'pad_w' and 'pad_h' module parameters into internal
> driver defines (ATOMISP_PAD_W and ATOMISP_PAD_H).
> Patch 2 removes 'dbg_level' and 'dbg_func' module parameters and updates
> ia_css_debug_vdtrace() to filter trace logging to IA_CSS_DEBUG_WARNING
> level or below to avoid potential dmesg log flooding.
>
> Output Behavior Difference:
> - Before: Trace logging depended on setting dbg_level via module
> parameters. Higher values flooded dmesg with verbose low-level trace
> messages.
> - After: Trace logging is filtered at IA_CSS_DEBUG_WARNING via standard
> vprintk facilities, avoiding dmesg flooding while maintaining
> critical warnings.
Why do you think this is good enough? I already pointed out that this
needs the report from the field, id est showing the before and after on
real hardware. Also I mentioned that printk() is not good for low-level
traces and we _have_ the mechanisms for that kind of messages, exempli
gratia trace events and trace points.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-11 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YOUR_ANDY_EMAIL_MESSAGE_ID_HERE>
2026-07-22 5:46 ` [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver Prajval Chaudhary
2026-07-22 5:46 ` [PATCH v5 1/2] staging: media: atomisp: Remove pad_w and pad_h module parameters Prajval Chaudhary
2026-07-22 5:46 ` [PATCH v5 2/2] staging: media: atomisp: Remove dbg_level and dbg_func " Prajval Chaudhary
2026-08-11 14:02 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ansrhooPovRKlz3v@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=prajvalchaudhari733@gmail.com \
--cc=sakari.ailios@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox